From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: "Георгий Кириченко" <georgy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH v3 06/14] txn: get rid of fiber_gc from txn_rollback
Date: Fri, 14 Jun 2019 12:21:14 +0300 [thread overview]
Message-ID: <20190614092114.fhwpvfjjw5g7kv6u@esperanza> (raw)
In-Reply-To: <6794812.AW9IRRbO8A@home.lan>
On Thu, Jun 13, 2019 at 10:28:24PM +0300, Георгий Кириченко wrote:
> On Thursday, June 13, 2019 5:12:56 PM MSK Vladimir Davydov wrote:
> > On Sun, Jun 09, 2019 at 11:44:35PM +0300, Georgy Kirichenko wrote:
> > > Don't touch a fiber gc storage on a transaction rollback explicitly.
> ...
> >
> > As I wrote earlier, I'm pretty convinced we don't need to call
> > fiber_gc() after txn_commit/rollback at all. Please consider
> > removing it in a separate patch.
> I call fiber_gc in such cases only in order to preserve the previous behavior.
> I think we could remove fiber_gc when all transaction data would be placed onto
> transaction memory. We could talk about f2f
Discussed f2f. Agreed to try to remove fiber_gc() calls after
txn_commit/rollback() first.
next prev parent reply other threads:[~2019-06-14 9:21 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 20:44 [tarantool-patches] [PATCH v3 00/14] Parallel applier Georgy Kirichenko
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 01/14] txn: Fire a trigger after a transaction finalization Georgy Kirichenko
2019-06-09 21:59 ` [tarantool-patches] " Konstantin Osipov
2019-06-11 11:42 ` [tarantool-patches] " Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 02/14] ddl: synchronize privileges cache with actual data state Georgy Kirichenko
2019-06-11 13:13 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 03/14] txn: transaction memory allocation Georgy Kirichenko
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 04/14] ddl: place alter structures onto a txn memory region Georgy Kirichenko
2019-06-11 14:14 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 05/14] txn: get rid of autocommit from a txn structure Georgy Kirichenko
2019-06-13 14:11 ` Vladimir Davydov
2019-06-16 16:20 ` [tarantool-patches] " Konstantin Osipov
2019-06-16 16:14 ` Konstantin Osipov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 06/14] txn: get rid of fiber_gc from txn_rollback Georgy Kirichenko
2019-06-13 14:12 ` Vladimir Davydov
2019-06-13 19:28 ` Георгий Кириченко
2019-06-14 9:21 ` Vladimir Davydov [this message]
2019-06-16 16:38 ` [tarantool-patches] " Konstantin Osipov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 07/14] wal: remove fiber from a journal_entry structure Georgy Kirichenko
2019-06-13 14:17 ` Vladimir Davydov
2019-06-13 19:33 ` Георгий Кириченко
2019-06-14 8:05 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 08/14] wal: enable asyncronous wal writes Georgy Kirichenko
2019-06-13 14:21 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 09/14] wal: a dedicated wal scheduling fiber Georgy Kirichenko
2019-06-13 14:24 ` Vladimir Davydov
2019-06-13 19:36 ` Георгий Кириченко
2019-06-14 9:20 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 10/14] core: latch_unlock_external routine Georgy Kirichenko
2019-06-13 14:27 ` Vladimir Davydov
2019-06-13 19:38 ` Георгий Кириченко
2019-06-14 8:10 ` Vladimir Davydov
2019-06-14 9:18 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 11/14] txn: introduce asynchronous txn commit Georgy Kirichenko
2019-06-13 14:34 ` Vladimir Davydov
2019-06-13 19:45 ` Георгий Кириченко
2019-06-14 7:58 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 12/14] txn: handle fiber stop event at transaction level Georgy Kirichenko
2019-06-13 14:36 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 13/14] applier: apply transaction in parallel Georgy Kirichenko
2019-06-13 15:17 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 14/14] test: fix flaky test Georgy Kirichenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614092114.fhwpvfjjw5g7kv6u@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=georgy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH v3 06/14] txn: get rid of fiber_gc from txn_rollback' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox