From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: "Георгий Кириченко" <georgy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH v3 10/14] core: latch_unlock_external routine
Date: Fri, 14 Jun 2019 12:18:14 +0300 [thread overview]
Message-ID: <20190614091814.5afs42xrfomaw7j3@esperanza> (raw)
In-Reply-To: <20190614081008.zyuol6q6hn2qxlff@esperanza>
On Fri, Jun 14, 2019 at 11:10:08AM +0300, Vladimir Davydov wrote:
> On Thu, Jun 13, 2019 at 10:38:12PM +0300, Георгий Кириченко wrote:
> > On Thursday, June 13, 2019 5:27:35 PM MSK Vladimir Davydov wrote:
> > > On Sun, Jun 09, 2019 at 11:44:39PM +0300, Georgy Kirichenko wrote:
> > >
> > > Again, looks like a temporary hack to me. I would rather not commit it.
> > > The right way would be getting rid of the schema_lock. I know that you
> > > have tried, but failed because of vylog. I'll look what we can do about
> > > it.
> > I failed to remove the latch from checkpoint not from ddl. Removing the latch
> > from alter.cc doesn't look possible in the next 2-3 month.
>
> I'll look what we can do about this - AFAICS there are no problems with
> memtx. We just need to tweak vinyl somehow.
Discussed f2f. Looks like we can't easily remove the latch, because we
do need it for synching DDL-vs-DDL (we can remove it from checkpointing,
but that's not enough).
Still, latch_unlock_external looks so ugly :(
May be, we could move it to be called before submitting a record to WAL
rather than after? Something like, before_commit trigger, may be?
next prev parent reply other threads:[~2019-06-14 9:18 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 20:44 [tarantool-patches] [PATCH v3 00/14] Parallel applier Georgy Kirichenko
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 01/14] txn: Fire a trigger after a transaction finalization Georgy Kirichenko
2019-06-09 21:59 ` [tarantool-patches] " Konstantin Osipov
2019-06-11 11:42 ` [tarantool-patches] " Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 02/14] ddl: synchronize privileges cache with actual data state Georgy Kirichenko
2019-06-11 13:13 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 03/14] txn: transaction memory allocation Georgy Kirichenko
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 04/14] ddl: place alter structures onto a txn memory region Georgy Kirichenko
2019-06-11 14:14 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 05/14] txn: get rid of autocommit from a txn structure Georgy Kirichenko
2019-06-13 14:11 ` Vladimir Davydov
2019-06-16 16:20 ` [tarantool-patches] " Konstantin Osipov
2019-06-16 16:14 ` Konstantin Osipov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 06/14] txn: get rid of fiber_gc from txn_rollback Georgy Kirichenko
2019-06-13 14:12 ` Vladimir Davydov
2019-06-13 19:28 ` Георгий Кириченко
2019-06-14 9:21 ` Vladimir Davydov
2019-06-16 16:38 ` [tarantool-patches] " Konstantin Osipov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 07/14] wal: remove fiber from a journal_entry structure Georgy Kirichenko
2019-06-13 14:17 ` Vladimir Davydov
2019-06-13 19:33 ` Георгий Кириченко
2019-06-14 8:05 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 08/14] wal: enable asyncronous wal writes Georgy Kirichenko
2019-06-13 14:21 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 09/14] wal: a dedicated wal scheduling fiber Georgy Kirichenko
2019-06-13 14:24 ` Vladimir Davydov
2019-06-13 19:36 ` Георгий Кириченко
2019-06-14 9:20 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 10/14] core: latch_unlock_external routine Georgy Kirichenko
2019-06-13 14:27 ` Vladimir Davydov
2019-06-13 19:38 ` Георгий Кириченко
2019-06-14 8:10 ` Vladimir Davydov
2019-06-14 9:18 ` Vladimir Davydov [this message]
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 11/14] txn: introduce asynchronous txn commit Georgy Kirichenko
2019-06-13 14:34 ` Vladimir Davydov
2019-06-13 19:45 ` Георгий Кириченко
2019-06-14 7:58 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 12/14] txn: handle fiber stop event at transaction level Georgy Kirichenko
2019-06-13 14:36 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 13/14] applier: apply transaction in parallel Georgy Kirichenko
2019-06-13 15:17 ` Vladimir Davydov
2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 14/14] test: fix flaky test Georgy Kirichenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614091814.5afs42xrfomaw7j3@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=georgy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH v3 10/14] core: latch_unlock_external routine' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox