* [tarantool-patches] [PATCH v1] test: replication/misc fix for high load
@ 2019-06-07 13:25 Alexander V. Tikhonov
2019-06-10 6:07 ` [tarantool-patches] " Alexander Turenko
2019-06-13 8:21 ` Kirill Yukhin
0 siblings, 2 replies; 6+ messages in thread
From: Alexander V. Tikhonov @ 2019-06-07 13:25 UTC (permalink / raw)
To: Alexander Turenko; +Cc: Alexander V. Tikhonov, tarantool-patches
Fixed test replication/misc to be able to run it on
hosts under high load. Changed downstream check to
use test_run:wait_downstream() function, to wait for
certain box.info.replication values to fix the error:
[050] replication/misc.test.lua [ fail ]
[050]
[050] Test failed! Result content mismatch:
[050] --- replication/misc.result Thu Jun 6 06:46:54 2019
[050] +++ replication/misc.reject Fri Jun 7 05:55:00 2019
[050] @@ -622,7 +622,7 @@
[050] ...
[050] box.info.replication[2].downstream.status
[050] ---
[050] -- stopped
[050] +- follow
[050] ...
[050] test_run:cmd("stop server replica")
[050] ---
Closes #4277
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4277-test-replication-misc
Issue: https://github.com/tarantool/tarantool/issues/4277
test/replication/misc.result | 4 ++--
test/replication/misc.test.lua | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/replication/misc.result b/test/replication/misc.result
index 5d7a6512e..f896ee4a9 100644
--- a/test/replication/misc.result
+++ b/test/replication/misc.result
@@ -620,9 +620,9 @@ test_run:wait_log("replica", "REPLICASET_UUID_MISMATCH", nil, 1.0)
---
- REPLICASET_UUID_MISMATCH
...
-box.info.replication[2].downstream.status
+test_run:wait_downstream(2, {status = 'stopped'})
---
-- stopped
+- true
...
test_run:cmd("stop server replica")
---
diff --git a/test/replication/misc.test.lua b/test/replication/misc.test.lua
index 5a6cecfaa..4be12ba3b 100644
--- a/test/replication/misc.test.lua
+++ b/test/replication/misc.test.lua
@@ -251,7 +251,7 @@ _ = box.space._schema:replace{'cluster', tostring(uuid.new())}
-- master believes replica is in cluster, but their cluster UUIDs differ.
test_run:cmd("start server replica")
test_run:wait_log("replica", "REPLICASET_UUID_MISMATCH", nil, 1.0)
-box.info.replication[2].downstream.status
+test_run:wait_downstream(2, {status = 'stopped'})
test_run:cmd("stop server replica")
test_run:cmd("cleanup server replica")
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [tarantool-patches] Re: [PATCH v1] test: replication/misc fix for high load 2019-06-07 13:25 [tarantool-patches] [PATCH v1] test: replication/misc fix for high load Alexander V. Tikhonov @ 2019-06-10 6:07 ` Alexander Turenko 2019-06-11 7:22 ` Serge Petrenko 2019-06-13 8:21 ` Kirill Yukhin 1 sibling, 1 reply; 6+ messages in thread From: Alexander Turenko @ 2019-06-10 6:07 UTC (permalink / raw) To: Alexander V. Tikhonov; +Cc: tarantool-patches, Serge Petrenko I'm okay. Serge, do you have any objections? WBR, Alexander Turenko. On Fri, Jun 07, 2019 at 04:25:12PM +0300, Alexander V. Tikhonov wrote: > Fixed test replication/misc to be able to run it on > hosts under high load. Changed downstream check to > use test_run:wait_downstream() function, to wait for > certain box.info.replication values to fix the error: > > [050] replication/misc.test.lua [ fail ] > [050] > [050] Test failed! Result content mismatch: > [050] --- replication/misc.result Thu Jun 6 06:46:54 2019 > [050] +++ replication/misc.reject Fri Jun 7 05:55:00 2019 > [050] @@ -622,7 +622,7 @@ > [050] ... > [050] box.info.replication[2].downstream.status > [050] --- > [050] -- stopped > [050] +- follow > [050] ... > [050] test_run:cmd("stop server replica") > [050] --- > > Closes #4277 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4277-test-replication-misc > Issue: https://github.com/tarantool/tarantool/issues/4277 > > test/replication/misc.result | 4 ++-- > test/replication/misc.test.lua | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/test/replication/misc.result b/test/replication/misc.result > index 5d7a6512e..f896ee4a9 100644 > --- a/test/replication/misc.result > +++ b/test/replication/misc.result > @@ -620,9 +620,9 @@ test_run:wait_log("replica", "REPLICASET_UUID_MISMATCH", nil, 1.0) > --- > - REPLICASET_UUID_MISMATCH > ... > -box.info.replication[2].downstream.status > +test_run:wait_downstream(2, {status = 'stopped'}) > --- > -- stopped > +- true > ... > test_run:cmd("stop server replica") > --- > diff --git a/test/replication/misc.test.lua b/test/replication/misc.test.lua > index 5a6cecfaa..4be12ba3b 100644 > --- a/test/replication/misc.test.lua > +++ b/test/replication/misc.test.lua > @@ -251,7 +251,7 @@ _ = box.space._schema:replace{'cluster', tostring(uuid.new())} > -- master believes replica is in cluster, but their cluster UUIDs differ. > test_run:cmd("start server replica") > test_run:wait_log("replica", "REPLICASET_UUID_MISMATCH", nil, 1.0) > -box.info.replication[2].downstream.status > +test_run:wait_downstream(2, {status = 'stopped'}) > > test_run:cmd("stop server replica") > test_run:cmd("cleanup server replica") > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [tarantool-patches] Re: [PATCH v1] test: replication/misc fix for high load 2019-06-10 6:07 ` [tarantool-patches] " Alexander Turenko @ 2019-06-11 7:22 ` Serge Petrenko 2019-06-11 7:37 ` Alexander Turenko 0 siblings, 1 reply; 6+ messages in thread From: Serge Petrenko @ 2019-06-11 7:22 UTC (permalink / raw) To: Alexander Turenko; +Cc: Alexander V. Tikhonov, tarantool-patches > 10 июня 2019 г., в 9:07, Alexander Turenko <alexander.turenko@tarantool.org> написал(а): > > I'm okay. > > Serge, do you have any objections? Looks good to me. -- Serge Petrenko sergepetrenko@tarantool.org > > WBR, Alexander Turenko. > > On Fri, Jun 07, 2019 at 04:25:12PM +0300, Alexander V. Tikhonov wrote: >> Fixed test replication/misc to be able to run it on >> hosts under high load. Changed downstream check to >> use test_run:wait_downstream() function, to wait for >> certain box.info.replication values to fix the error: >> >> [050] replication/misc.test.lua [ fail ] >> [050] >> [050] Test failed! Result content mismatch: >> [050] --- replication/misc.result Thu Jun 6 06:46:54 2019 >> [050] +++ replication/misc.reject Fri Jun 7 05:55:00 2019 >> [050] @@ -622,7 +622,7 @@ >> [050] ... >> [050] box.info.replication[2].downstream.status >> [050] --- >> [050] -- stopped >> [050] +- follow >> [050] ... >> [050] test_run:cmd("stop server replica") >> [050] --- >> >> Closes #4277 >> --- >> >> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4277-test-replication-misc >> Issue: https://github.com/tarantool/tarantool/issues/4277 >> >> test/replication/misc.result | 4 ++-- >> test/replication/misc.test.lua | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/test/replication/misc.result b/test/replication/misc.result >> index 5d7a6512e..f896ee4a9 100644 >> --- a/test/replication/misc.result >> +++ b/test/replication/misc.result >> @@ -620,9 +620,9 @@ test_run:wait_log("replica", "REPLICASET_UUID_MISMATCH", nil, 1.0) >> --- >> - REPLICASET_UUID_MISMATCH >> ... >> -box.info.replication[2].downstream.status >> +test_run:wait_downstream(2, {status = 'stopped'}) >> --- >> -- stopped >> +- true >> ... >> test_run:cmd("stop server replica") >> --- >> diff --git a/test/replication/misc.test.lua b/test/replication/misc.test.lua >> index 5a6cecfaa..4be12ba3b 100644 >> --- a/test/replication/misc.test.lua >> +++ b/test/replication/misc.test.lua >> @@ -251,7 +251,7 @@ _ = box.space._schema:replace{'cluster', tostring(uuid.new())} >> -- master believes replica is in cluster, but their cluster UUIDs differ. >> test_run:cmd("start server replica") >> test_run:wait_log("replica", "REPLICASET_UUID_MISMATCH", nil, 1.0) >> -box.info.replication[2].downstream.status >> +test_run:wait_downstream(2, {status = 'stopped'}) >> >> test_run:cmd("stop server replica") >> test_run:cmd("cleanup server replica") >> -- >> 2.17.1 >> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [tarantool-patches] Re: [PATCH v1] test: replication/misc fix for high load 2019-06-11 7:22 ` Serge Petrenko @ 2019-06-11 7:37 ` Alexander Turenko 0 siblings, 0 replies; 6+ messages in thread From: Alexander Turenko @ 2019-06-11 7:37 UTC (permalink / raw) To: Kirill Yukhin; +Cc: Alexander V. Tikhonov, tarantool-patches, Serge Petrenko Kirill, please, proceed. I would fix it down to 1.10. WBR, Alexander Turenko. On Tue, Jun 11, 2019 at 10:22:08AM +0300, Serge Petrenko wrote: > > > 10 июня 2019 г., в 9:07, Alexander Turenko <alexander.turenko@tarantool.org> написал(а): > > > > I'm okay. > > > > Serge, do you have any objections? > > Looks good to me. > > -- > Serge Petrenko > sergepetrenko@tarantool.org > > > > > WBR, Alexander Turenko. > > > > On Fri, Jun 07, 2019 at 04:25:12PM +0300, Alexander V. Tikhonov wrote: > >> Fixed test replication/misc to be able to run it on > >> hosts under high load. Changed downstream check to > >> use test_run:wait_downstream() function, to wait for > >> certain box.info.replication values to fix the error: > >> > >> [050] replication/misc.test.lua [ fail ] > >> [050] > >> [050] Test failed! Result content mismatch: > >> [050] --- replication/misc.result Thu Jun 6 06:46:54 2019 > >> [050] +++ replication/misc.reject Fri Jun 7 05:55:00 2019 > >> [050] @@ -622,7 +622,7 @@ > >> [050] ... > >> [050] box.info.replication[2].downstream.status > >> [050] --- > >> [050] -- stopped > >> [050] +- follow > >> [050] ... > >> [050] test_run:cmd("stop server replica") > >> [050] --- > >> > >> Closes #4277 > >> --- > >> > >> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4277-test-replication-misc > >> Issue: https://github.com/tarantool/tarantool/issues/4277 > >> > >> test/replication/misc.result | 4 ++-- > >> test/replication/misc.test.lua | 2 +- > >> 2 files changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/test/replication/misc.result b/test/replication/misc.result > >> index 5d7a6512e..f896ee4a9 100644 > >> --- a/test/replication/misc.result > >> +++ b/test/replication/misc.result > >> @@ -620,9 +620,9 @@ test_run:wait_log("replica", "REPLICASET_UUID_MISMATCH", nil, 1.0) > >> --- > >> - REPLICASET_UUID_MISMATCH > >> ... > >> -box.info.replication[2].downstream.status > >> +test_run:wait_downstream(2, {status = 'stopped'}) > >> --- > >> -- stopped > >> +- true > >> ... > >> test_run:cmd("stop server replica") > >> --- > >> diff --git a/test/replication/misc.test.lua b/test/replication/misc.test.lua > >> index 5a6cecfaa..4be12ba3b 100644 > >> --- a/test/replication/misc.test.lua > >> +++ b/test/replication/misc.test.lua > >> @@ -251,7 +251,7 @@ _ = box.space._schema:replace{'cluster', tostring(uuid.new())} > >> -- master believes replica is in cluster, but their cluster UUIDs differ. > >> test_run:cmd("start server replica") > >> test_run:wait_log("replica", "REPLICASET_UUID_MISMATCH", nil, 1.0) > >> -box.info.replication[2].downstream.status > >> +test_run:wait_downstream(2, {status = 'stopped'}) > >> > >> test_run:cmd("stop server replica") > >> test_run:cmd("cleanup server replica") > >> -- > >> 2.17.1 > >> > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [tarantool-patches] Re: [PATCH v1] test: replication/misc fix for high load 2019-06-07 13:25 [tarantool-patches] [PATCH v1] test: replication/misc fix for high load Alexander V. Tikhonov 2019-06-10 6:07 ` [tarantool-patches] " Alexander Turenko @ 2019-06-13 8:21 ` Kirill Yukhin 2019-06-13 9:50 ` Alexander Turenko 1 sibling, 1 reply; 6+ messages in thread From: Kirill Yukhin @ 2019-06-13 8:21 UTC (permalink / raw) To: tarantool-patches; +Cc: Alexander Turenko, Alexander V. Tikhonov Hello, On 07 Jun 16:25, Alexander V. Tikhonov wrote: > Fixed test replication/misc to be able to run it on > hosts under high load. Changed downstream check to > use test_run:wait_downstream() function, to wait for > certain box.info.replication values to fix the error: > > [050] replication/misc.test.lua [ fail ] > [050] > [050] Test failed! Result content mismatch: > [050] --- replication/misc.result Thu Jun 6 06:46:54 2019 > [050] +++ replication/misc.reject Fri Jun 7 05:55:00 2019 > [050] @@ -622,7 +622,7 @@ > [050] ... > [050] box.info.replication[2].downstream.status > [050] --- > [050] -- stopped > [050] +- follow > [050] ... > [050] test_run:cmd("stop server replica") > [050] --- > > Closes #4277 I've checked your patch into 2.1 and master. -- Regards, Kirill Yukhin ^ permalink raw reply [flat|nested] 6+ messages in thread
* [tarantool-patches] Re: [PATCH v1] test: replication/misc fix for high load 2019-06-13 8:21 ` Kirill Yukhin @ 2019-06-13 9:50 ` Alexander Turenko 0 siblings, 0 replies; 6+ messages in thread From: Alexander Turenko @ 2019-06-13 9:50 UTC (permalink / raw) To: Kirill Yukhin; +Cc: tarantool-patches, Alexander V. Tikhonov On Thu, Jun 13, 2019 at 11:21:32AM +0300, Kirill Yukhin wrote: > Hello, > > On 07 Jun 16:25, Alexander V. Tikhonov wrote: > > Fixed test replication/misc to be able to run it on > > hosts under high load. Changed downstream check to > > use test_run:wait_downstream() function, to wait for > > certain box.info.replication values to fix the error: > > > > [050] replication/misc.test.lua [ fail ] > > [050] > > [050] Test failed! Result content mismatch: > > [050] --- replication/misc.result Thu Jun 6 06:46:54 2019 > > [050] +++ replication/misc.reject Fri Jun 7 05:55:00 2019 > > [050] @@ -622,7 +622,7 @@ > > [050] ... > > [050] box.info.replication[2].downstream.status > > [050] --- > > [050] -- stopped > > [050] +- follow > > [050] ... > > [050] test_run:cmd("stop server replica") > > [050] --- > > > > Closes #4277 > > I've checked your patch into 2.1 and master. It worth to have green CI on 1.10 too. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-13 9:51 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-06-07 13:25 [tarantool-patches] [PATCH v1] test: replication/misc fix for high load Alexander V. Tikhonov 2019-06-10 6:07 ` [tarantool-patches] " Alexander Turenko 2019-06-11 7:22 ` Serge Petrenko 2019-06-11 7:37 ` Alexander Turenko 2019-06-13 8:21 ` Kirill Yukhin 2019-06-13 9:50 ` Alexander Turenko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox