Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>,
	tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1] test: use unix sockets for iproto connections
Date: Fri, 7 Jun 2019 08:20:42 +0300	[thread overview]
Message-ID: <20190607052042.5bbr35un3wtqm3bh@tarantool.org> (raw)
In-Reply-To: <7c079ab85610e4f7c68662a0bff6fad3d0a4fbd7.1559881217.git.avtikhon@tarantool.org>

Hello,

On 07 Jun 07:21, Alexander V. Tikhonov wrote:
> From: avtikhon <avtikhon@tarantool.org>
> 
> Enabled use_unix_sockets_iproto option to use unix sockets
> iproto provides the new way to handle the problem with
> 'Address already in use' error. It lets test-run appoint
> unix sockets for LISTEN environment variable values.
> 
> Before this change the TcpPortDispatcher was used to
> eliminate the race condition when two workers trying to use
> the same port: the idea was that each worker used its own
> ports range. Really these ports could race with client ports
> (from, say, net.box or replication), which typically didn't
> use bind() and so bound to a random available port (despite
> any dispatched ranges) and could produce 'Address already in
> use' error.
> 
> Closes: #4008
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4008-test-in-parallel-iproto
> Issue: https://github.com/tarantool/tarantool/issues/4008

I've checked your patch into master and 2.1 branch.

--
Regards, Kirill Yukhin

  reply	other threads:[~2019-06-07  5:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-07  4:21 [tarantool-patches] " Alexander V. Tikhonov
2019-06-07  5:20 ` Kirill Yukhin [this message]
2019-06-07 16:12   ` [tarantool-patches] " Alexander Turenko
     [not found] <8390add718a4ba07836c2143ca3286df8c577ff3.1562316047.git.avtikhon@tarantool.org>
2019-07-05 15:02 ` Alexander Turenko
     [not found] <8390add718a4ba07836c2143ca3286df8c577ff3.1562587370.git.avtikhon@tarantool.org>
2019-07-08 21:45 ` Alexander Turenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190607052042.5bbr35un3wtqm3bh@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v1] test: use unix sockets for iproto connections' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox