From: Alexander Turenko <alexander.turenko@tarantool.org> To: "Alexander V. Tikhonov" <avtikhon@tarantool.org> Cc: tarantool-patches@freelists.org Subject: [tarantool-patches] Re: [PATCH v1 1/2] Enable http_client test Date: Fri, 7 Jun 2019 05:40:59 +0300 [thread overview] Message-ID: <20190607024058.kvxe36zkrchoznmv@tkn_work_nb> (raw) In-Reply-To: <00daa2bd0e72231f71a09c80b7f45516481b3418.1559823465.git.avtikhon@tarantool.org> I'm okay with the code, but see minor comments below. LGTM formally, please fix the comments and proceed with Kirill directly. I would not split the patchset into two commits, just mention that you're reverts changes made by the certain commit. BTW, don't forget to write a cover letter when sending a patchset of more then one patch (it is not applicable here however if you'll squash this patchset, just reminder). Please, use prefix 'test: ' for commits that changes only tests. WBR, Alexander Turenko. On Thu, Jun 06, 2019 at 03:24:54PM +0300, Alexander V. Tikhonov wrote: > Removed skip flag file to switch on the testing of the > http_client test. Enabled http_client test on OSX, > fixed missing of the python2 link. Removed the subtest I would be more specific: link -> symlink. > on '595 error return' from 'error' suite, due to it may > hang forever. > > Closes #4254 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4254-try-on-travis > Issue: https://github.com/tarantool/tarantool/issues/4254
prev parent reply other threads:[~2019-06-07 2:41 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-06 12:24 [tarantool-patches] " Alexander V. Tikhonov 2019-06-06 12:24 ` [tarantool-patches] [PATCH v1 2/2] Revert "Disable flaky http_client.test.lua" Alexander V. Tikhonov 2019-06-07 2:40 ` Alexander Turenko [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190607024058.kvxe36zkrchoznmv@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=avtikhon@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v1 1/2] Enable http_client test' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox