* [PATCH] test: fix box/net.box.test.lua result file
@ 2019-06-07 1:11 Alexander Turenko
2019-06-07 1:14 ` Alexander Turenko
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Turenko @ 2019-06-07 1:11 UTC (permalink / raw)
To: tarantool-patches; +Cc: Alexander Turenko, Roman Khabibov, Vladimir Davydov
This is the regression from a7c855e5bd486a3392138b4f743abd6cb1d13fff
(net.box: fetch '_vcollation' sysview into the module). The result file
was corrupted, because the test sometimes produces incorrect result in
the test case for on_connect / on_disconnect triggers. This issue is
tracked by #4273.
Follow up #3941.
---
branch: https://github.com/tarantool/tarantool/tree/Totktonada/fix-net-box-test
issue: https://github.com/tarantool/tarantool/issues/3941
related: https://github.com/tarantool/tarantool/issues/4273
test/box/net.box.result | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/box/net.box.result b/test/box/net.box.result
index 9c516fff5..474297af3 100644
--- a/test/box/net.box.result
+++ b/test/box/net.box.result
@@ -2339,14 +2339,14 @@ connected_cnt
...
disconnected_cnt
---
-- 2
+- 1
...
conn:close()
---
...
disconnected_cnt
---
-- 3
+- 2
...
test_run:cmd('stop server connecter')
---
--
2.21.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] test: fix box/net.box.test.lua result file
2019-06-07 1:11 [PATCH] test: fix box/net.box.test.lua result file Alexander Turenko
@ 2019-06-07 1:14 ` Alexander Turenko
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Turenko @ 2019-06-07 1:14 UTC (permalink / raw)
To: tarantool-patches; +Cc: Roman Khabibov, Vladimir Davydov
Pushed to master as trivial.
WBR, Alexander Turenko.
On Fri, Jun 07, 2019 at 04:11:39AM +0300, Alexander Turenko wrote:
> This is the regression from a7c855e5bd486a3392138b4f743abd6cb1d13fff
> (net.box: fetch '_vcollation' sysview into the module). The result file
> was corrupted, because the test sometimes produces incorrect result in
> the test case for on_connect / on_disconnect triggers. This issue is
> tracked by #4273.
>
> Follow up #3941.
> ---
>
> branch: https://github.com/tarantool/tarantool/tree/Totktonada/fix-net-box-test
> issue: https://github.com/tarantool/tarantool/issues/3941
> related: https://github.com/tarantool/tarantool/issues/4273
>
> test/box/net.box.result | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/box/net.box.result b/test/box/net.box.result
> index 9c516fff5..474297af3 100644
> --- a/test/box/net.box.result
> +++ b/test/box/net.box.result
> @@ -2339,14 +2339,14 @@ connected_cnt
> ...
> disconnected_cnt
> ---
> -- 2
> +- 1
> ...
> conn:close()
> ---
> ...
> disconnected_cnt
> ---
> -- 3
> +- 2
> ...
> test_run:cmd('stop server connecter')
> ---
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-07 1:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-07 1:11 [PATCH] test: fix box/net.box.test.lua result file Alexander Turenko
2019-06-07 1:14 ` Alexander Turenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox