Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Roman Khabibov <roman.habibov@tarantool.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH] test: fix box/net.box.test.lua result file
Date: Fri, 7 Jun 2019 04:14:38 +0300	[thread overview]
Message-ID: <20190607011437.6kdereb5wzleah2l@tkn_work_nb> (raw)
In-Reply-To: <32e63308ae0cf04a97c7b385fde99feb87d68e9a.1559868594.git.alexander.turenko@tarantool.org>

Pushed to master as trivial.

WBR, Alexander Turenko.

On Fri, Jun 07, 2019 at 04:11:39AM +0300, Alexander Turenko wrote:
> This is the regression from a7c855e5bd486a3392138b4f743abd6cb1d13fff
> (net.box: fetch '_vcollation' sysview into the module). The result file
> was corrupted, because the test sometimes produces incorrect result in
> the test case for on_connect / on_disconnect triggers. This issue is
> tracked by #4273.
> 
> Follow up #3941.
> ---
> 
> branch: https://github.com/tarantool/tarantool/tree/Totktonada/fix-net-box-test
> issue: https://github.com/tarantool/tarantool/issues/3941
> related: https://github.com/tarantool/tarantool/issues/4273
> 
>  test/box/net.box.result | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/test/box/net.box.result b/test/box/net.box.result
> index 9c516fff5..474297af3 100644
> --- a/test/box/net.box.result
> +++ b/test/box/net.box.result
> @@ -2339,14 +2339,14 @@ connected_cnt
>  ...
>  disconnected_cnt
>  ---
> -- 2
> +- 1
>  ...
>  conn:close()
>  ---
>  ...
>  disconnected_cnt
>  ---
> -- 3
> +- 2
>  ...
>  test_run:cmd('stop server connecter')
>  ---
> -- 
> 2.21.0
> 

      reply	other threads:[~2019-06-07  1:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-07  1:11 Alexander Turenko
2019-06-07  1:14 ` Alexander Turenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190607011437.6kdereb5wzleah2l@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=roman.habibov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH] test: fix box/net.box.test.lua result file' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox