From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: korablev@tarantool.org
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: move space existence check to VDBE
Date: Thu, 6 Jun 2019 17:07:46 +0300 [thread overview]
Message-ID: <20190606140746.f6mbjurtbyrjmahq@tarantool.org> (raw)
In-Reply-To: <08ea8b249e2d04ec819a2e5bd9487619fcf87a4c.1557334891.git.imeevma@gmail.com>
Hello,
On 08 May 20:02, imeevma@tarantool.org wrote:
> Before this patch, the existence of space was checked for the
> CREATE TABLE or CREATE VIEW statements during the parsing. If the
> space already exists, an error has been set and cleanup is
> performed. But, if the statement contained 'IF NOT EXIST', the
> cleanup was performed, but the error was not set. This causes an
> error when creating a foreign key during space creation.
>
> This patch moves this check to VDBE. Thus, the parsing should now
> be properly closed before performing this check.
>
> Closes #4196
> ---
> https://github.com/tarantool/tarantool/issues/4196
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4196-move-space-existence-check-to-vdbe
I've checked your patch into 2.1 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-06-06 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 17:02 [tarantool-patches] " imeevma
2019-05-11 11:56 ` [tarantool-patches] " n.pettik
2019-05-15 18:37 ` Mergen Imeev
2019-05-30 14:44 ` n.pettik
2019-06-06 14:07 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606140746.f6mbjurtbyrjmahq@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: move space existence check to VDBE' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox