From: Konstantin Osipov <kostja@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 1/5] test: create isolated ev_loop for swim unit tests
Date: Wed, 5 Jun 2019 09:51:55 +0300 [thread overview]
Message-ID: <20190605065155.GB28736@atlas> (raw)
In-Reply-To: <50a84d1ffdd25646894e576ef4ff19195aaf769e.1559433539.git.v.shpilevoy@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/06/03 14:33]:
> --- a/src/lib/swim/swim_ev.c
> +++ b/src/lib/swim/swim_ev.c
> @@ -55,3 +55,9 @@ swim_ev_timer_stop(struct ev_loop *loop, struct ev_timer *watcher)
> {
> ev_timer_stop(loop, watcher);
> }
> +
> +struct ev_loop *
> +swim_loop(void)
The comment explaining why you need a separate loop should be
here, not in the tests, since this is the place most people will
be looking at and wondering why you need this wrapper at all.
You could hack this around with a define, but I think your
approach is more clean, so please just add a comment.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-06-05 12:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 0:00 [tarantool-patches] [PATCH 0/5] SWIM on_member_update Vladislav Shpilevoy
2019-06-02 0:00 ` [tarantool-patches] [PATCH 1/5] test: create isolated ev_loop for swim unit tests Vladislav Shpilevoy
2019-06-05 6:51 ` Konstantin Osipov [this message]
2019-06-05 21:53 ` [tarantool-patches] " Vladislav Shpilevoy
2019-06-08 14:24 ` Konstantin Osipov
2019-06-02 0:00 ` [tarantool-patches] [PATCH 2/5] swim: fix a 'use after free' in SWIM tests Vladislav Shpilevoy
2019-06-05 6:52 ` [tarantool-patches] " Konstantin Osipov
2019-06-02 0:00 ` [tarantool-patches] [PATCH 3/5] swim: allow to hang triggers on member updates Vladislav Shpilevoy
2019-06-05 7:11 ` [tarantool-patches] " Konstantin Osipov
2019-06-05 21:53 ` Vladislav Shpilevoy
2019-06-07 13:35 ` Konstantin Osipov
2019-06-02 0:00 ` [tarantool-patches] [PATCH 4/5] swim: call swim:new/delete via Lua C, not via FFI Vladislav Shpilevoy
2019-06-08 14:24 ` [tarantool-patches] " Konstantin Osipov
2019-06-02 0:10 ` [tarantool-patches] [PATCH 5/5] swim: expose Lua triggers on member update Vladislav Shpilevoy
2019-06-05 21:54 ` [tarantool-patches] " Vladislav Shpilevoy
2019-06-08 14:29 ` Konstantin Osipov
[not found] ` <12b8ea76f7c1cd100a80ddcea3c29d20354e073e.1559433539.git.v.shpilevoy@tarantool.org>
2019-06-08 14:27 ` Konstantin Osipov
2019-06-08 19:52 ` Vladislav Shpilevoy
2019-06-09 5:15 ` Konstantin Osipov
2019-06-09 16:41 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605065155.GB28736@atlas \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 1/5] test: create isolated ev_loop for swim unit tests' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox