From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 03/10] vinyl: move vylog recovery to vylog thread
Date: Sat, 1 Jun 2019 11:36:00 +0300 [thread overview]
Message-ID: <20190601083600.GD29429@atlas> (raw)
In-Reply-To: <69dfb6ed09c655e842ae9200598fce9c62176998.1558103547.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [19/05/17 17:54]:
> We used coio, because vylog was written from a WAL thread, which
> shouldn't be used for such a heavy operation as vylog recovery.
> Now, we can move it to the dedicated vylog thread. This allows
> us to simplify rotation logic as well: now most of work is done
> from the same function (vy_log_rotate_f) executed by vylog thread,
> not scattered between coio and WAL, as it used to be.
Why do we need to lock out the scheduler while rotating the log in
the first place?
This is not anywhere in the comments, and vy_log was renamed from
xctl so I got lost in the commit history.
It's a pity it's not reflected in the comment.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-06-01 9:16 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 14:52 [PATCH 00/10] vinyl: don't yield in DDL on_commit triggers Vladimir Davydov
2019-05-17 14:52 ` [PATCH 01/10] box: zap atfork callback Vladimir Davydov
2019-05-18 18:37 ` [tarantool-patches] " Konstantin Osipov
2019-05-20 8:13 ` Vladimir Davydov
2019-06-01 8:16 ` Konstantin Osipov
2019-06-06 10:04 ` Vladimir Davydov
2019-05-17 14:52 ` [PATCH 02/10] vinyl: add a separate thread for vylog Vladimir Davydov
2019-05-18 18:39 ` [tarantool-patches] " Konstantin Osipov
2019-05-20 8:17 ` Vladimir Davydov
2019-06-01 8:26 ` Konstantin Osipov
2019-06-06 10:20 ` Vladimir Davydov
2019-05-17 14:52 ` [PATCH 03/10] vinyl: move vylog recovery to vylog thread Vladimir Davydov
2019-06-01 8:36 ` Konstantin Osipov [this message]
2019-06-06 10:23 ` [tarantool-patches] " Vladimir Davydov
2019-06-07 13:39 ` Konstantin Osipov
2019-06-10 15:24 ` Vladimir Davydov
2019-06-07 13:40 ` Konstantin Osipov
2019-05-17 14:52 ` [PATCH 04/10] vinyl: rework vylog transaction backlog implementation Vladimir Davydov
2019-06-01 8:38 ` [tarantool-patches] " Konstantin Osipov
2019-06-06 11:58 ` Vladimir Davydov
2019-05-17 14:52 ` [PATCH 05/10] vinyl: don't purge deleted runs from vylog on compaction Vladimir Davydov
2019-05-18 18:47 ` [tarantool-patches] " Konstantin Osipov
2019-05-20 8:27 ` Vladimir Davydov
2019-06-01 8:39 ` Konstantin Osipov
2019-06-06 12:40 ` Vladimir Davydov
2019-05-17 14:52 ` [PATCH 06/10] vinyl: lock out compaction while checkpointing is in progress Vladimir Davydov
2019-05-17 14:52 ` [PATCH 07/10] vinyl: don't access last vylog signature outside vylog implementation Vladimir Davydov
2019-05-17 14:52 ` [PATCH 08/10] vinyl: zap ERRINJ_VY_LOG_FLUSH_DELAY Vladimir Davydov
2019-05-17 14:52 ` [PATCH 09/10] key_def: pass alloc callback to key_def_dump_parts Vladimir Davydov
2019-05-18 18:52 ` [tarantool-patches] " Konstantin Osipov
2019-05-20 8:34 ` Vladimir Davydov
2019-06-01 8:41 ` Konstantin Osipov
2019-06-10 15:28 ` Vladimir Davydov
2019-06-16 14:57 ` Konstantin Osipov
2019-05-17 14:52 ` [PATCH 10/10] vinyl: get rid of the latch protecting vylog buffer Vladimir Davydov
2019-06-01 8:44 ` [tarantool-patches] " Konstantin Osipov
2019-06-06 13:15 ` Vladimir Davydov
2019-05-18 18:35 ` [tarantool-patches] Re: [PATCH 00/10] vinyl: don't yield in DDL on_commit triggers Konstantin Osipov
2019-05-20 8:09 ` Vladimir Davydov
2019-06-01 8:09 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190601083600.GD29429@atlas \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 03/10] vinyl: move vylog recovery to vylog thread' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox