From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] vinyl: don't throttle DDL
Date: Fri, 31 May 2019 13:11:17 +0300 [thread overview]
Message-ID: <20190531101117.GA10100@atlas> (raw)
In-Reply-To: <6a44ac6225255600cdc0ab8c082c04c9e98f89f8.1559296816.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [19/05/31 13:01]:
> Since DDL is triggered by the admin, it can be deliberately initiated
> when the workload is known to be low. Throttling it along with DML
> requests would only cause exasperation in this case. So we don't apply
> disk-based rate limit to DDL. This should be fine, because the
> disk-based limit is set rather strictly to let the workload some space
> to grow, see vy_regulator_update_rate_limit(), and in contrast to the
> memory-based limit, exceeding the disk-based limit doesn't result in
> abrupt stalls - it may only lead to a gradual accumulation of disk space
> usage and read latency.
>
> Closes #4238
Nice that you provisioned for this in advance. LGTM.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-05-31 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 10:00 Vladimir Davydov
2019-05-31 10:11 ` Konstantin Osipov [this message]
2019-05-31 10:35 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531101117.GA10100@atlas \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] vinyl: don'\''t throttle DDL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox