From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 5/5] vinyl: lookup key in reader thread
Date: Wed, 29 May 2019 21:41:45 +0300 [thread overview]
Message-ID: <20190529184145.GE6799@atlas> (raw)
In-Reply-To: <999913620b7ef6cb0c30333d83fa7bcdfacfb955.1559142561.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [19/05/29 21:03]:
> If a key isn't found in the tuple cache, we fetch it from a run file. In
> this case disk read and page decompression is done by a reader thread,
> however key lookup in the fetched page is still performed by the tx
> thread. Since pages are immutable, this could as well be done by the
> reader thread, which would allow us to save some precious CPU cycles for
> tx.
>
> Close #4257
> ---
This patch is LGTM. The next logical step is moving vy_page_xrow
and vy_page_stmt calls to the reader thread, but this would be
more messy I guess. I'd guess they also consume quite a bit of CPU,
however.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-05-29 18:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 15:12 [PATCH 0/5] Hand over key lookup in a page to vinyl " Vladimir Davydov
2019-05-29 15:12 ` [PATCH 1/5] vinyl: factor out function to lookup key in page Vladimir Davydov
2019-05-29 18:16 ` [tarantool-patches] " Konstantin Osipov
2019-05-29 15:12 ` [PATCH 2/5] vinyl: pass page info by reference to reader thread Vladimir Davydov
2019-05-29 18:16 ` [tarantool-patches] " Konstantin Osipov
2019-05-29 15:12 ` [PATCH 3/5] vinyl: encapsulate reader thread selection logic in a helper function Vladimir Davydov
2019-05-29 18:24 ` [tarantool-patches] " Konstantin Osipov
2019-05-29 15:12 ` [PATCH 4/5] vinyl: do not allow to cancel a fiber reading a page Vladimir Davydov
2019-05-29 18:35 ` [tarantool-patches] " Konstantin Osipov
2019-05-29 15:12 ` [PATCH 5/5] vinyl: lookup key in reader thread Vladimir Davydov
2019-05-29 18:41 ` Konstantin Osipov [this message]
2019-05-30 8:42 ` [PATCH 0/5] Hand over key lookup in a page to vinyl " Vladimir Davydov
2019-05-30 14:20 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529184145.GE6799@atlas \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 5/5] vinyl: lookup key in reader thread' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox