From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org, kostja@tarantool.org
Subject: Re: [PATCH v3 2/2] test: move background index build test to engine suite from vinyl
Date: Wed, 29 May 2019 19:03:02 +0300 [thread overview]
Message-ID: <20190529160302.kzpgqjcymufnbcfc@esperanza> (raw)
In-Reply-To: <87a3ff76ed05d1f42d569e162ab5125cd51b781e.1559056498.git.sergepetrenko@tarantool.org>
On Tue, May 28, 2019 at 06:33:25PM +0300, Serge Petrenko wrote:
> +-- check that index build is aborted in case conflicting tuple is inserted
> +-- error injection makes index build yield after 1 tuple is inserted into
> +-- new index, check that index build is aborted if unique constraint is
> +-- violated, as well as if tuple format doesn't match the new indexes one.
> +box.error.injection.set('ERRINJ_BUILD_INDEX_DELAY', 0.001)
Please use boolean error injection if possible, i.e. loop until it is
cleared. Timeouts are very unreliable in parallel test run.
Also, it looks like this test shouldn'be run in the release mode.
Worth adding engine/errinj_ddl.test.lua?
Also, vinyl has similar tests too, see vinyl/errinj_ddl.test.lua.
It would be great if you could unify them using this new error
injection you introduce.
next prev parent reply other threads:[~2019-05-29 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 15:33 [PATCH v3 0/2] memtx: add yields during index build Serge Petrenko
2019-05-28 15:33 ` [PATCH v3 1/2] " Serge Petrenko
2019-05-29 15:58 ` Vladimir Davydov
2019-05-28 15:33 ` [PATCH v3 2/2] test: move background index build test to engine suite from vinyl Serge Petrenko
2019-05-28 15:39 ` [tarantool-patches] " Serge Petrenko
2019-05-29 16:03 ` Vladimir Davydov [this message]
2019-05-29 11:01 ` [PATCH v3 0/2] memtx: add yields during index build Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529160302.kzpgqjcymufnbcfc@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH v3 2/2] test: move background index build test to engine suite from vinyl' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox