Tarantool development patches archive
 help / color / mirror / Atom feed
* [tarantool-patches] [PATCH luajit] bugfix: fixed assertion failure "lj_record.c:92: rec_check_slots: Assertion `nslots <= 250' failed" found by stressing our edgelang compiler.
@ 2019-05-28 18:57 Cyrill Gorcunov
  2019-05-28 23:33 ` [tarantool-patches] " Kirill Yukhin
  2019-05-29 14:29 ` Kirill Yukhin
  0 siblings, 2 replies; 5+ messages in thread
From: Cyrill Gorcunov @ 2019-05-28 18:57 UTC (permalink / raw)
  To: tarantool; +Cc: Kirill Yukhin, Alexander Turenko

From: "Yichun Zhang (agentzh)" <yichun@openresty.com>

Fixes #4053
---
https://github.com/tarantool/tarantool/issues/4053
As being requested by @olegrok

 src/lj_record.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/lj_record.c b/src/lj_record.c
index fe9691d..55aa565 100644
--- a/src/lj_record.c
+++ b/src/lj_record.c
@@ -1860,6 +1860,8 @@ static void rec_varg(jit_State *J, BCReg dst, ptrdiff_t nresults)
       lj_trace_err_info(J, LJ_TRERR_NYIBC);
     }
   }
+  if (J->baseslot + J->maxslot >= LJ_MAX_JSLOTS)
+    lj_trace_err(J, LJ_TRERR_STACKOV);
 }
 
 /* -- Record allocations -------------------------------------------------- */
-- 
2.20.1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [tarantool-patches] Re: [PATCH luajit] bugfix: fixed assertion failure "lj_record.c:92: rec_check_slots: Assertion `nslots <= 250' failed" found by stressing our edgelang compiler.
  2019-05-28 18:57 [tarantool-patches] [PATCH luajit] bugfix: fixed assertion failure "lj_record.c:92: rec_check_slots: Assertion `nslots <= 250' failed" found by stressing our edgelang compiler Cyrill Gorcunov
@ 2019-05-28 23:33 ` Kirill Yukhin
  2019-05-28 23:51   ` Alexander Turenko
  2019-05-29  6:52   ` Cyrill Gorcunov
  2019-05-29 14:29 ` Kirill Yukhin
  1 sibling, 2 replies; 5+ messages in thread
From: Kirill Yukhin @ 2019-05-28 23:33 UTC (permalink / raw)
  To: Cyrill Gorcunov; +Cc: tarantool, Alexander Turenko

Hello,

On 28 May 21:57, Cyrill Gorcunov wrote:
> From: "Yichun Zhang (agentzh)" <yichun@openresty.com>
> 
> Fixes #4053
> ---
> https://github.com/tarantool/tarantool/issues/4053
> As being requested by @olegrok

No test in original patch as well?

--
Regards, Kirill Yukhin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [tarantool-patches] Re: [PATCH luajit] bugfix: fixed assertion failure "lj_record.c:92: rec_check_slots: Assertion `nslots <= 250' failed" found by stressing our edgelang compiler.
  2019-05-28 23:33 ` [tarantool-patches] " Kirill Yukhin
@ 2019-05-28 23:51   ` Alexander Turenko
  2019-05-29  6:52   ` Cyrill Gorcunov
  1 sibling, 0 replies; 5+ messages in thread
From: Alexander Turenko @ 2019-05-28 23:51 UTC (permalink / raw)
  To: Kirill Yukhin; +Cc: Cyrill Gorcunov, tarantool

On Wed, May 29, 2019 at 02:33:48AM +0300, Kirill Yukhin wrote:
> Hello,
> 
> On 28 May 21:57, Cyrill Gorcunov wrote:
> > From: "Yichun Zhang (agentzh)" <yichun@openresty.com>
> > 
> > Fixes #4053
> > ---
> > https://github.com/tarantool/tarantool/issues/4053
> > As being requested by @olegrok
> 
> No test in original patch as well?

AFAIK, no.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [tarantool-patches] Re: [PATCH luajit] bugfix: fixed assertion failure "lj_record.c:92: rec_check_slots: Assertion `nslots <= 250' failed" found by stressing our edgelang compiler.
  2019-05-28 23:33 ` [tarantool-patches] " Kirill Yukhin
  2019-05-28 23:51   ` Alexander Turenko
@ 2019-05-29  6:52   ` Cyrill Gorcunov
  1 sibling, 0 replies; 5+ messages in thread
From: Cyrill Gorcunov @ 2019-05-29  6:52 UTC (permalink / raw)
  To: Kirill Yukhin; +Cc: tarantool, Alexander Turenko

On Wed, May 29, 2019 at 02:33:48AM +0300, Kirill Yukhin wrote:
> Hello,
> 
> On 28 May 21:57, Cyrill Gorcunov wrote:
> > From: "Yichun Zhang (agentzh)" <yichun@openresty.com>
> > 
> > Fixes #4053
> > ---
> > https://github.com/tarantool/tarantool/issues/4053
> > As being requested by @olegrok
> 
> No test in original patch as well?

Didn't find any.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [tarantool-patches] Re: [PATCH luajit] bugfix: fixed assertion failure "lj_record.c:92: rec_check_slots: Assertion `nslots <= 250' failed" found by stressing our edgelang compiler.
  2019-05-28 18:57 [tarantool-patches] [PATCH luajit] bugfix: fixed assertion failure "lj_record.c:92: rec_check_slots: Assertion `nslots <= 250' failed" found by stressing our edgelang compiler Cyrill Gorcunov
  2019-05-28 23:33 ` [tarantool-patches] " Kirill Yukhin
@ 2019-05-29 14:29 ` Kirill Yukhin
  1 sibling, 0 replies; 5+ messages in thread
From: Kirill Yukhin @ 2019-05-29 14:29 UTC (permalink / raw)
  To: Cyrill Gorcunov; +Cc: tarantool, Alexander Turenko

Hello,

On 28 May 21:57, Cyrill Gorcunov wrote:
> From: "Yichun Zhang (agentzh)" <yichun@openresty.com>
> 
> Fixes #4053
> ---
> https://github.com/tarantool/tarantool/issues/4053
> As being requested by @olegrok

I've checked your patch into 1.10, 2.1 and master.

--
Regards, Kirill Yukhin

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-05-29 14:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-28 18:57 [tarantool-patches] [PATCH luajit] bugfix: fixed assertion failure "lj_record.c:92: rec_check_slots: Assertion `nslots <= 250' failed" found by stressing our edgelang compiler Cyrill Gorcunov
2019-05-28 23:33 ` [tarantool-patches] " Kirill Yukhin
2019-05-28 23:51   ` Alexander Turenko
2019-05-29  6:52   ` Cyrill Gorcunov
2019-05-29 14:29 ` Kirill Yukhin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox