From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH] schema: rework index sequence API
Date: Tue, 28 May 2019 12:38:25 +0300 [thread overview]
Message-ID: <20190528093825.GB7254@atlas> (raw)
In-Reply-To: <20190528074112.wsu75ir4okez75as@esperanza>
* Vladimir Davydov <vdavydov.dev@gmail.com> [19/05/28 10:42]:
> > What happens when I rename the field using space::format()?
> > Does sequence continue to work? Which field is it using then?
>
> I guess, just like indexes, sequences should be attached not to a field
> name, but to a field no so nothing will happen when a field is renamed.
>
> >
> > What happens when if I alter the index and modify its part names, order
> > or count? The answer to this question depends on whether
> > _sequence_space stores the path or the part.
>
> If we store fieldno+path, there will be an error altering the index
> unless sequence is modified as well. I guess that's okay.
>
> >
> > If you think using a field is a stupid idea and the core should
> > continue using part no, please, test the consequences of this at
> > least.
Thanks. The above questions were suggestions for test cases,
actually.
--
Konstantin Osipov, Moscow, Russia
prev parent reply other threads:[~2019-05-28 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 16:00 Vladimir Davydov
2019-05-27 19:38 ` [tarantool-patches] " Konstantin Osipov
2019-05-28 7:41 ` Vladimir Davydov
2019-05-28 9:38 ` Konstantin Osipov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528093825.GB7254@atlas \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [PATCH] schema: rework index sequence API' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox