From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@freelists.org>,
Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/2] luajit2: bugfix: fixed a segfault when unsinking 64-bit pointers
Date: Mon, 27 May 2019 10:12:58 +0300 [thread overview]
Message-ID: <20190527071256.543y6thlccivknir@tkn_work_nb> (raw)
In-Reply-To: <20190523174634.32314-1-gorcunov@gmail.com>
LGTM.
Kirill, please proceed. I think we should push this fix for all
currently supported branches.
Please, close issue https://github.com/tarantool/tarantool/issues/4072
from the commit message in a commit for tarantool repo.
WBR, Alexader Turenko.
On Thu, May 23, 2019 at 08:46:32PM +0300, Cyrill Gorcunov wrote:
> The series fixes segfault when unsinking 64-bit pointers.
> Note that I've backported a patch and a test for us but
> the problem didn't trigger for me even when luajit2 is
> unpatched.
>
> That said up to you, still think it might be usefull for
> case #4171
This issue is reproduced on Linux, where we don't use GC64, so it is not
related.
next prev parent reply other threads:[~2019-05-27 7:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 17:46 [tarantool-patches] " Cyrill Gorcunov
2019-05-23 17:48 ` [tarantool-patches] [PATCH 1/2] " Cyrill Gorcunov
2019-05-23 17:49 ` [tarantool-patches] [PATCH 2/2] test/luajit-tap: Add unsink_64_kptr.test.lua Cyrill Gorcunov
2019-05-23 17:50 ` [tarantool-patches] Re: [PATCH 0/2] luajit2: bugfix: fixed a segfault when unsinking 64-bit pointers Cyrill Gorcunov
2019-05-24 17:38 ` Alexander Turenko
2019-05-24 20:39 ` Cyrill Gorcunov
2019-05-27 7:12 ` Alexander Turenko [this message]
2019-05-28 2:02 ` Kirill Yukhin
2019-05-28 12:01 ` Alexander Turenko
2019-05-28 12:11 ` Cyrill Gorcunov
2019-05-28 12:14 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527071256.543y6thlccivknir@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 0/2] luajit2: bugfix: fixed a segfault when unsinking 64-bit pointers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox