From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH 1/3] vinyl: fix secondary index divergence on update
Date: Sun, 26 May 2019 17:36:13 +0300 [thread overview]
Message-ID: <20190526143613.23whsddiae3g64nh@esperanza> (raw)
In-Reply-To: <20190525202851.GB2340@atlas>
On Sat, May 25, 2019 at 11:28:51PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/05/25 22:55]:
> > On Sat, May 25, 2019 at 09:11:57AM +0300, Konstantin Osipov wrote:
> > > Could you also please explain why you decided to introduce a new
> > > flag, and not use is_overwritten?
> >
> > is_overwritten is cleared on rollback while is_nop stays unchanged.
>
> Then shouldn't better name be is_overwriting, as every
> is_overwritten txv is overwritten by some is_overwriting txv
> (is_nop)? Is there any symmetry between the two or there are cases
> when they are unrelated?
No.
is_nop is set if a statement has no effect and can be skipped on commit,
e.g. DELETE following REPLACE in case of a secondary index.
Not every statement that overwrites some other statement has no effect,
e.g. REPLACE following other REPLACE can't be skipped.
next prev parent reply other threads:[~2019-05-26 14:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 21:53 [PATCH 0/3] Fixes of a few Vinyl transaction manager issues Vladimir Davydov
2019-05-24 21:53 ` [PATCH 1/3] vinyl: fix secondary index divergence on update Vladimir Davydov
2019-05-25 6:11 ` [tarantool-patches] " Konstantin Osipov
2019-05-25 19:51 ` Vladimir Davydov
2019-05-25 20:28 ` Konstantin Osipov
2019-05-26 14:36 ` Vladimir Davydov [this message]
[not found] ` <CAPZPwLoP+SEO2WbTavgtR3feWN4tX81GAYw5ZYp4_pC5JkyS_A@mail.gmail.com>
2019-05-27 8:28 ` Vladimir Davydov
2019-05-24 21:53 ` [PATCH 2/3] vinyl: don't produce deferred DELETE on commit if key isn't updated Vladimir Davydov
2019-05-25 6:13 ` [tarantool-patches] " Konstantin Osipov
2019-05-24 21:53 ` [PATCH 3/3] vinyl: fix deferred DELETE statement lost on commit Vladimir Davydov
2019-05-25 6:15 ` [tarantool-patches] " Konstantin Osipov
2019-05-27 8:29 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190526143613.23whsddiae3g64nh@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] Re: [PATCH 1/3] vinyl: fix secondary index divergence on update' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox