From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tml <tarantool-patches@freelists.org>,
Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/2] luajit2: bugfix: fixed a segfault when unsinking 64-bit pointers
Date: Fri, 24 May 2019 23:39:01 +0300 [thread overview]
Message-ID: <20190524203901.GI11013@uranus> (raw)
In-Reply-To: <20190524173831.peewq44nttk7bwtv@tkn_work_nb>
On Fri, May 24, 2019 at 08:38:33PM +0300, Alexander Turenko wrote:
> On Thu, May 23, 2019 at 08:46:32PM +0300, Cyrill Gorcunov wrote:
> > The series fixes segfault when unsinking 64-bit pointers.
> > Note that I've backported a patch and a test for us but
> > the problem didn't trigger for me even when luajit2 is
> > unpatched.
>
> Did you try with -DLUAJIT_ENABLE_GC64=ON cmake option?
I didn't. Rerun now with -DLUAJIT_ENABLE_GC64=ON and without
the patch test fails indeed. Thus we need this fix together
with a test. Thanks for the hint!
next prev parent reply other threads:[~2019-05-24 20:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 17:46 [tarantool-patches] " Cyrill Gorcunov
2019-05-23 17:48 ` [tarantool-patches] [PATCH 1/2] " Cyrill Gorcunov
2019-05-23 17:49 ` [tarantool-patches] [PATCH 2/2] test/luajit-tap: Add unsink_64_kptr.test.lua Cyrill Gorcunov
2019-05-23 17:50 ` [tarantool-patches] Re: [PATCH 0/2] luajit2: bugfix: fixed a segfault when unsinking 64-bit pointers Cyrill Gorcunov
2019-05-24 17:38 ` Alexander Turenko
2019-05-24 20:39 ` Cyrill Gorcunov [this message]
2019-05-27 7:12 ` Alexander Turenko
2019-05-28 2:02 ` Kirill Yukhin
2019-05-28 12:01 ` Alexander Turenko
2019-05-28 12:11 ` Cyrill Gorcunov
2019-05-28 12:14 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524203901.GI11013@uranus \
--to=gorcunov@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 0/2] luajit2: bugfix: fixed a segfault when unsinking 64-bit pointers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox