From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 2/2] tuple format: remove invalid assertion from tuple_format_iterator_next
Date: Wed, 22 May 2019 22:01:33 +0300 [thread overview]
Message-ID: <20190522190133.GB22098@atlas> (raw)
In-Reply-To: <aad779db4511f48845cb82f4c73dcb9dfe3b854b.1558538748.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [19/05/22 18:46]:
> It's too early to assert msgpack type as an array when a multikey field
> is encountered - we haven't checked the field type yet so the type might
> as well be a map, in which case we will raise an error just a few lines
> below. Remove the assertion and add a test case.
I assume you pushed as obvious already, lgtm anywya.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-05-22 19:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 15:26 [PATCH 1/2] tuple format: don't allow null where array/map is expected Vladimir Davydov
2019-05-22 15:26 ` [PATCH 2/2] tuple format: remove invalid assertion from tuple_format_iterator_next Vladimir Davydov
2019-05-22 19:01 ` Konstantin Osipov [this message]
2019-05-22 20:37 ` Vladimir Davydov
2019-05-22 19:00 ` [tarantool-patches] Re: [PATCH 1/2] tuple format: don't allow null where array/map is expected Konstantin Osipov
2019-05-22 20:37 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522190133.GB22098@atlas \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 2/2] tuple format: remove invalid assertion from tuple_format_iterator_next' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox