Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 0/4] A few fixes/improvements for autoincrement indexes
Date: Tue, 21 May 2019 19:02:35 +0300	[thread overview]
Message-ID: <20190521160235.mpfphhtlopijbqoj@tarantool.org> (raw)
In-Reply-To: <20190521145837.GA15755@atlas>

Hello,

On 21 май 17:58, Konstantin Osipov wrote:
> * Kirill Yukhin <kyukhin@tarantool.org> [19/05/21 13:43]:
> > Hello,
> 
> > >   schema: explicitly forbid setting sequence for json path key part
> 
> I asked to use an existing option and allow field names in the
> patch, e.g. sequece = path.to.field.

Do you suggest to allow assigning a sequence to JSON path?

> I don't see that this is done in the patch.
> 
> Why did you check it in?

Vova replied you here [1], this might be useful follow-up, but
right now looks like this is out of scope of the request. They
just need to be able to set sequence to an arbitrary index part.
Since five days pass w/o answer I've checked it into master.

[1] - https://www.freelists.org/post/tarantool-patches/PATCH-34-schema-allow-to-set-sequence-for-any-index-part-not-just-the-first,2

--
Regards, Kirill Yukhin

      reply	other threads:[~2019-05-21 16:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 10:33 Vladimir Davydov
2019-05-15 10:33 ` [PATCH 1/4] schema: use tuple field names in Lua Vladimir Davydov
2019-05-15 10:33 ` [PATCH 2/4] schema: fix error while altering index with sequence Vladimir Davydov
2019-05-16  7:45   ` [tarantool-patches] " Konstantin Osipov
2019-05-15 10:33 ` [PATCH 3/4] schema: allow to set sequence for any index part, not just the first Vladimir Davydov
2019-05-16  7:45   ` [tarantool-patches] " Konstantin Osipov
2019-05-16  8:02     ` Vladimir Davydov
2019-05-15 10:33 ` [PATCH 4/4] schema: explicitly forbid setting sequence for json path key part Vladimir Davydov
2019-05-15 13:00   ` [tarantool-patches] " Konstantin Osipov
2019-05-15 13:11     ` Vladimir Davydov
2019-05-15 13:16       ` Vladimir Davydov
2019-05-15 13:44         ` [PATCH] box: fix autoincrement for json path indexes Vladimir Davydov
2019-05-16  7:42           ` [tarantool-patches] " Konstantin Osipov
2019-05-21 13:28             ` Vladimir Davydov
2019-05-21 10:42 ` [tarantool-patches] Re: [PATCH 0/4] A few fixes/improvements for autoincrement indexes Kirill Yukhin
2019-05-21 14:58   ` Konstantin Osipov
2019-05-21 16:02     ` Kirill Yukhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521160235.mpfphhtlopijbqoj@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 0/4] A few fixes/improvements for autoincrement indexes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox