From: Alexander Turenko <alexander.turenko@tarantool.org> To: "Alexander V. Tikhonov" <avtikhon@tarantool.org> Cc: tarantool-patches@freelists.org Subject: [tarantool-patches] Re: [PATCH v2] travis-ci: fix LTO and clang Date: Mon, 20 May 2019 18:08:23 +0300 [thread overview] Message-ID: <20190520150823.dnnumkmazd4cg5kx@tkn_work_nb> (raw) In-Reply-To: <75a27a279a4f307cd2cb9a4f96cb71dcdcee9201.1558099514.git.avtikhon@tarantool.org> Pushed to master, 2.1 and 1.10. 1.10 has no LTO targets, but I saved CMAKE_EXTRA_PARAMS to keep CI related files as similar as possible and because we possibly will need it for GitLab CI targets. I fixed minor points here and there, see below. WBR, Alexander Turenko. On Fri, May 17, 2019 at 04:25:49PM +0300, Alexander V. Tikhonov wrote: > Made fixes: > > - Added CMAKE_EXTRA_PARAMS environment to docker's container > runs to enable -DENABLE_LTO=ON/OFF cmake option. > > - Added CC/CXX environment to docker's container runs to set > clang for cmake. Also the additional environment variables > {CC,CXX}_FOR_BUILD were not postponed, because we didn't were postponed? Fixed. > run cross-compilation at the moment, for more info check: > > https://docs.travis-ci.com/user/languages/cpp/#choosing-compilers-to-test-against > > @@ -214,15 +214,17 @@ sql_value_double(sql_value * pVal) > bool > sql_value_boolean(sql_value *val) > { > - bool b; > - mem_value_bool((struct Mem *) val, &b); > + bool b = false; > + int rc = mem_value_bool((struct Mem *) val, &b); > + assert(rc == 0); > + (void) rc; We use tab symbol for indentation in C sources. Fixed. > diff --git a/src/httpc.c b/src/httpc.c > index d8ab27ef0..84bf2413c 100644 > --- a/src/httpc.c > +++ b/src/httpc.c > @@ -267,7 +267,8 @@ httpc_set_low_speed_limit(struct httpc_request *req, long low_speed_limit) > void > httpc_set_verbose(struct httpc_request *req, bool curl_verbose) > { > - curl_easy_setopt(req->curl_request.easy, CURLOPT_VERBOSE, curl_verbose); > + curl_easy_setopt(req->curl_request.easy, CURLOPT_VERBOSE, > + (long) curl_verbose); Added a whitespace to indent '(long) curl_verbose' on the same column with 'req->curl_request.easy'. > } > > void
prev parent reply other threads:[~2019-05-20 15:08 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-17 13:25 [tarantool-patches] " Alexander V. Tikhonov 2019-05-20 15:08 ` Alexander Turenko [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190520150823.dnnumkmazd4cg5kx@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=avtikhon@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v2] travis-ci: fix LTO and clang' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox