From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@freelists.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [PATCH v5 1/2] slab_arena: Enhance slab_arena_create to support madvise hints
Date: Mon, 20 May 2019 15:55:39 +0300 [thread overview]
Message-ID: <20190520125538.fwvy2lj53bhvwdzj@esperanza> (raw)
In-Reply-To: <20190516214559.3310-2-gorcunov@gmail.com>
On Fri, May 17, 2019 at 12:45:58AM +0300, Cyrill Gorcunov wrote:
> @@ -157,6 +206,9 @@ slab_arena_create(struct slab_arena *arena, struct quota *quota,
> } else {
> arena->arena = NULL;
> }
> +
> + madvise_checked(arena->arena, arena->slab_size, arena->flags);
> +
Apparently, you should use arena->prealloc here. Fixed and pushed the
patch set to master (both tarantool and tarantool-small).
next prev parent reply other threads:[~2019-05-20 12:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 21:45 [PATCH v5 0/2] Implement support of strip_core functionality Cyrill Gorcunov
2019-05-16 21:45 ` [PATCH v5 1/2] slab_arena: Enhance slab_arena_create to support madvise hints Cyrill Gorcunov
2019-05-20 12:55 ` Vladimir Davydov [this message]
2019-05-20 13:03 ` Cyrill Gorcunov
2019-05-16 21:45 ` [PATCH v5 2/2] box/memtx: Allow to skip tuple memory from coredump Cyrill Gorcunov
2019-05-20 10:03 ` [PATCH v5 0/2] Implement support of strip_core functionality Vladimir Davydov
2019-05-20 10:09 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520125538.fwvy2lj53bhvwdzj@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH v5 1/2] slab_arena: Enhance slab_arena_create to support madvise hints' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox