Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org, vdavydov.dev@gmail.com
Subject: Re: [tarantool-patches] Re: [PATCH v1 2/3] schema: extend _func space to persist lua functions
Date: Fri, 17 May 2019 18:29:52 +0300	[thread overview]
Message-ID: <20190517152952.GB20341@atlas> (raw)
In-Reply-To: <92b6b7a0-7d8d-c239-6a40-b72f03f17e06@tarantool.org>

* Kirill Shcherbatov <kshcherbatov@tarantool.org> [19/05/17 15:37]:
> > While we are at it, I would also add 'type' - function or
> > procedure, and other related to SQL procedures fields.
> > 
> > See for example here:
> > 
> > https://mariadb.com/kb/en/library/mysqlproc-table/
> > (not all of these fields are relevant, and perhaps we need an
> > 'options' map, to make the whole thing easily extensible in the
> > future, but it's better to put as many fields as possible into
> > columns, not options).
> 
> Thank you for this reference.
> I think we'll need 'is_deterministic' flag soon enough (in scope of
> functional indexes), so I've introduced it.
> To make the process of introducing such options extensible,
> @locker and I decided to put 'is_deterministic' and other new
> flags in the 'opts' map field. I've reused existent opts_decode
> mechanism in scope of this patch.

I wrote earlier: it's better to put as many fields as possible to
columns, not options. 

If you disagree, please put forward your arguments first.

I don't mind options, but htey are hard to use, so should be
avoided if possible.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32

  reply	other threads:[~2019-05-17 15:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14 13:29 [PATCH v1 0/3] box: persistent Lua functions Kirill Shcherbatov
2019-05-14 13:29 ` [PATCH v1 1/3] box: refactor box_lua_find helper Kirill Shcherbatov
2019-05-17 12:33   ` [tarantool-patches] " Kirill Shcherbatov
2019-05-14 13:29 ` [PATCH v1 2/3] schema: extend _func space to persist lua functions Kirill Shcherbatov
2019-05-14 18:21   ` [tarantool-patches] " Konstantin Osipov
2019-05-17 12:33     ` [tarantool-patches] " Kirill Shcherbatov
2019-05-17 15:29       ` Konstantin Osipov [this message]
2019-05-14 13:29 ` [PATCH v1 3/3] box: extend box.schema.func with persistent folder Kirill Shcherbatov
2019-05-14 18:24   ` [tarantool-patches] " Konstantin Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190517152952.GB20341@atlas \
    --to=kostja@tarantool.org \
    --cc=kshcherbatov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [tarantool-patches] Re: [PATCH v1 2/3] schema: extend _func space to persist lua functions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox