Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: korablev@tarantool.org
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: do not replace the error with a syntax error
Date: Fri, 17 May 2019 14:40:12 +0300	[thread overview]
Message-ID: <20190517114012.h7p4avkd53pky6cc@tarantool.org> (raw)
In-Reply-To: <76ecaa6e2ba8a69f421a73bb25fb857cf5bbe001.1557244912.git.imeevma@gmail.com>

Hello,

On 07 May 19:03, imeevma@tarantool.org wrote:
> Currently, it is possible to set a syntax error, even if there has
> already been another error before.
> 
> For example:
> box.execute("insert into not_exist values(1) a")
> 
> The first error is "Space 'NOT_EXIST' does not exist", but "Syntax
> error near 'a'" is displayed.
> 
> After this patch, all syntax errors will be set only if there have
> been no errors before.
> 
> Closes #3964
> ---
> https://github.com/tarantool/tarantool/issues/3964
> https://github.com/tarantool/tarantool/tree/imeevma/gh-3964-stop-parser-on-error

I've checked your patch into master.

--
Regards, Kirill Yukhin

      parent reply	other threads:[~2019-05-17 11:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 16:03 [tarantool-patches] " imeevma
2019-05-11 12:39 ` [tarantool-patches] " n.pettik
2019-05-15 17:28   ` Mergen Imeev
2019-05-15 18:52     ` Mergen Imeev
2019-05-15 19:28       ` n.pettik
2019-05-15 19:33         ` Imeev Mergen
2019-05-16 23:05           ` n.pettik
2019-05-17 11:40 ` Kirill Yukhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190517114012.h7p4avkd53pky6cc@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: do not replace the error with a syntax error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox