Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: tml <tarantool-patches@freelists.org>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>,
	Alexander Turenko <alexander.turenko@tarantool.org>,
	gorcunov@gmail.com
Subject: [PATCH v5 0/2] Implement support of strip_core functionality
Date: Fri, 17 May 2019 00:45:57 +0300	[thread overview]
Message-ID: <20190516214559.3310-1-gorcunov@gmail.com> (raw)

The series patches both "small" memory engine and tarantool code as well,
moreover the tarantool patch depends on "small" new api.

Please review carefully. To test if memory doesn't go into coredump I've
been using gcore together with readelf utilities.

When strip_core is set to false (by default)

2019-05-16 23:53:28.755 [29583] main/102/interactive D> tuple arena memtx: addr 0x7f728c000000 size 268435456 flags 0x80000001 dontdump 0
2019-05-16 23:53:28.755 [29583] main/102/interactive I> mapping 134217728 bytes for vinyl tuple arena...

7f7283800000-7f729c081000 rw-p 00000000 00:00 0
VmFlags: rd wr mr mw me ac sd

  [34] load              PROGBITS         00007f7283800000  0df6e284
       0000000018881000  0000000000000000  WA       0     0     1

The segment with memtx memory is present inside corefile (because vma flags
are the same for both memtx and vynil os does merge the memory into single
vma).

In turn when strip_core is set to true we have

2019-05-16 23:58:26.796 [29852] main/102/interactive D> tuple arena memtx: addr 0x7f6978000000 size 268435456 flags 0x80000005 dontdump 1
2019-05-16 23:58:26.796 [29852] main/102/interactive I> mapping 134217728 bytes for vinyl tuple arena...

7f6978000000-7f6979000000 rw-p 00000000 00:00 0
VmFlags: rd wr mr mw me ac dd sd

  [36] load              PROGBITS         00007f6979000000  15f7d364
       000000000f000000  0000000000000000  WA       0     0     1

The memtx is not present in corefile but only vynil goes there.

Volodya, could you please help with more intensive testing since I'm not sure
how to fill memtx from console or some script yet.

Cyrill Gorcunov (2):
  slab_arena: Enhance slab_arena_create to support madvise hints
  box/memtx: Allow to skip tuple memory from coredump

-- 
2.20.1

             reply	other threads:[~2019-05-16 21:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16 21:45 Cyrill Gorcunov [this message]
2019-05-16 21:45 ` [PATCH v5 1/2] slab_arena: Enhance slab_arena_create to support madvise hints Cyrill Gorcunov
2019-05-20 12:55   ` Vladimir Davydov
2019-05-20 13:03     ` Cyrill Gorcunov
2019-05-16 21:45 ` [PATCH v5 2/2] box/memtx: Allow to skip tuple memory from coredump Cyrill Gorcunov
2019-05-20 10:03 ` [PATCH v5 0/2] Implement support of strip_core functionality Vladimir Davydov
2019-05-20 10:09   ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190516214559.3310-1-gorcunov@gmail.com \
    --to=gorcunov@gmail.com \
    --cc=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH v5 0/2] Implement support of strip_core functionality' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox