From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [tarantool-patches] [PATCH] iproto: init coio watcher before join/subscribe
Date: Thu, 16 May 2019 11:38:17 +0300 [thread overview]
Message-ID: <20190516083817.GN26670@atlas> (raw)
In-Reply-To: <26ee4f4b5fcc01bba7fb5b33fd97983fef1ac6f0.1557952229.git.alexander.turenko@tarantool.org>
* Alexander Turenko <alexander.turenko@tarantool.org> [19/05/16 09:53]:
> box_process_join() and box_process_subscribe() use coio_write_xrow(),
> which calls coio_writev_timeout() under hood. If a socket will block at
> write() the function calls ev_io_start() to wake the fiber up when the
> socket will be ready to write. This code assumes that the watcher
> (struct ev_io) is initialized as coio watcher, i.e. coio_create() has
> been called.
the same comment is missing from the source code.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
next prev parent reply other threads:[~2019-05-16 8:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 20:57 Alexander Turenko
2019-05-16 8:38 ` Konstantin Osipov [this message]
2019-05-16 11:46 ` [tarantool-patches] " Alexander Turenko
2019-05-20 9:41 ` Vladimir Davydov
2019-05-20 9:52 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190516083817.GN26670@atlas \
--to=kostja@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] [PATCH] iproto: init coio watcher before join/subscribe' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox