Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tml <tarantool-patches@freelists.org>,
	Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [PATCH v3] slab_arena: Enhance slab_arena_create to support madvise hints
Date: Wed, 15 May 2019 16:22:16 +0300	[thread overview]
Message-ID: <20190515132216.GE2952@uranus.lan> (raw)
In-Reply-To: <20190515130812.tvkrwnjclasvrbgn@esperanza>

On Wed, May 15, 2019 at 04:08:12PM +0300, Vladimir Davydov wrote:
> > 
> > You know I thought if we could use small/conf.h inside tarantool.
> > For this sake I prefixed symbols with TARANROOL_SMALL_ to not interfere
> > with any other symbols.
> > 
> > Another option -- provide something like
> > 
> > static const uint64_t small_features = (bitset of features);
> 
> I would define HAVE_MADV_DONTNEED in tarantool's config.h.

This won't work: you may have tarantool compiled on machine
where don't need not supported, but small compiled on a system
where madv is present (note that I'm talking about system libs,
the kernel may have own features enabled).

Also I think the main idea of "small" as a library is to separate
code as much as possible: tarantool should not do any own compile
testing but rather request the library if particular feature is
implemented (either via API or via config.h shipped with library).

Lets talk f2f.

> 
> It does compile on my box, which runs Linux. Note the cast: it should be
> fine to explicitly cast (char *) to intptr_t.

Weird, I'll retry.

      reply	other threads:[~2019-05-15 13:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13 20:01 Cyrill Gorcunov
2019-05-15 12:37 ` Vladimir Davydov
2019-05-15 12:53   ` Cyrill Gorcunov
2019-05-15 13:08     ` Vladimir Davydov
2019-05-15 13:22       ` Cyrill Gorcunov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190515132216.GE2952@uranus.lan \
    --to=gorcunov@gmail.com \
    --cc=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH v3] slab_arena: Enhance slab_arena_create to support madvise hints' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox