From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>,
tml <tarantool-patches@freelists.org>
Subject: Re: [PATCH v2] box/memtx: Allow to skip tuple memory from coredump
Date: Wed, 15 May 2019 15:54:41 +0300 [thread overview]
Message-ID: <20190515125441.GD2952@uranus.lan> (raw)
In-Reply-To: <20190515124558.7k6advlhcrr5r4dt@esperanza>
On Wed, May 15, 2019 at 03:45:58PM +0300, Vladimir Davydov wrote:
>
> Please patch all places to use the new API. This better be done in a
> separate patch. Call it "Update small submodule". Then I will squash
> submodule sha update in it once we are done.
>
> I checked - it turns out that SLAB_DONTDUMP path in madvise_checked is
> executed even if box.cfg.strip_core is false. Looks like flags aren't
> initialized properly somewhere. Please fix.
>
> Please double-check (manually) that this new option does reduce core
> size. Try setting box.cfg.memtx_memory, writing some data to a space,
> then increasing box.cfg.memtx_memory, writing more, crashing the app,
> and checking that the core size is significantly smaller with strip_core
> set.
>
> Also, as I mentioned in the comment to the previous patch, we should
> emit a warning in case MADV_DONTDUMP is unavailable while strip_core is
> set. This probably better be done here, in Tarantool, using say_warn.
Thanks for review! Will address.
prev parent reply other threads:[~2019-05-15 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 22:20 Cyrill Gorcunov
2019-05-15 12:45 ` Vladimir Davydov
2019-05-15 12:54 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515125441.GD2952@uranus.lan \
--to=gorcunov@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH v2] box/memtx: Allow to skip tuple memory from coredump' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox