From: Cyrill Gorcunov <gorcunov@gmail.com> To: Vladimir Davydov <vdavydov.dev@gmail.com> Cc: tml <tarantool-patches@freelists.org>, Alexander Turenko <alexander.turenko@tarantool.org> Subject: Re: [RFC v2] slab_arena: Enhance slab_arena_create to support madvise hints Date: Mon, 13 May 2019 15:02:37 +0300 [thread overview] Message-ID: <20190513120237.GE2544@uranus.lan> (raw) In-Reply-To: <20190513115643.26ysavw5a5izjruw@esperanza> On Mon, May 13, 2019 at 02:56:43PM +0300, Vladimir Davydov wrote: > > > > Because we need a default value, which would be different > > from MADV_DONTDUMP. Actually MADV_NORMAL = 0 in linux and > > If SLAB_DONTDUMP isn't set, we don't need to call madvise at all, do we? We don't, yes. > > > I think we may even live without this member initialized > > If we store SLAB_* flags in slab_arena instead of map_flags + madv_flags > we won't be facing this problem, will we? Then I think we will be able to drop it. I'll prepare a patch at the evening and we find out.
prev parent reply other threads:[~2019-05-13 12:02 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-06 17:43 Cyrill Gorcunov 2019-05-13 10:06 ` Vladimir Davydov 2019-05-13 10:30 ` Cyrill Gorcunov 2019-05-13 11:21 ` Vladimir Davydov 2019-05-13 11:41 ` Cyrill Gorcunov 2019-05-13 11:56 ` Vladimir Davydov 2019-05-13 12:02 ` Cyrill Gorcunov [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190513120237.GE2544@uranus.lan \ --to=gorcunov@gmail.com \ --cc=alexander.turenko@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [RFC v2] slab_arena: Enhance slab_arena_create to support madvise hints' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox