Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: replace schema_find_id() by box_space_id_by_name()
Date: Tue, 7 May 2019 19:41:02 +0300	[thread overview]
Message-ID: <20190507164102.GD10365@atlas> (raw)
In-Reply-To: <642C2122-385A-4FBB-86DB-DB75E77081E6@tarantool.org>

* n.pettik <korablev@tarantool.org> [19/05/07 19:21]:
> 
> > +-- Ensure that the CREATE TRIGGER statement cannot be executed if
> > +-- the user does not have enough rights. In this case, the user
> > +-- does not have rights to read from _space.
> > +--
> > +box.execute([[CREATE TRIGGER r1 AFTER INSERT ON t1 FOR EACH ROW BEGIN SELECT 1; END; ]])
> > +---
> > +- error: Space 'T1' does not exist
> 
> Such error looks a bit confusing IMHO. Could we tell the absence
> of space from lack of rights?

It's OK to produce a confusing error message for a user which has
no access to a space. This message is just fine. We should just be
consistent and not reveal that the space exists through the error
message.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32

  reply	other threads:[~2019-05-07 16:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-27 15:30 [tarantool-patches] " imeevma
2019-05-07 16:20 ` [tarantool-patches] " n.pettik
2019-05-07 16:41   ` Konstantin Osipov [this message]
2019-05-11 12:17     ` n.pettik
2019-05-17 11:43 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190507164102.GD10365@atlas \
    --to=kostja@tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: replace schema_find_id() by box_space_id_by_name()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox