Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v5 2/4] box: introduce field_map_builder class
Date: Mon, 6 May 2019 17:22:13 +0300	[thread overview]
Message-ID: <20190506142213.bvdgyoxie3calrvn@esperanza> (raw)
In-Reply-To: <e0e758660b3d4597e54e79cac6c1984674fdeb9c.1557142159.git.kshcherbatov@tarantool.org>

On Mon, May 06, 2019 at 02:57:39PM +0300, Kirill Shcherbatov wrote:
> The new field_map_builder class encapsulates the logic associated
> with field_map allocation and initialization. In the future it
> will be extended to allocate field_map that has extensions.
> 
> Needed for #1257
> ---
>  src/box/CMakeLists.txt |   1 +
>  src/box/field_map.c    |  61 ++++++++++++++++++
>  src/box/field_map.h    | 140 +++++++++++++++++++++++++++++++++++++++++
>  src/box/memtx_engine.c |   8 +--
>  src/box/sql.c          |   5 +-
>  src/box/tuple.c        |  14 ++---
>  src/box/tuple.h        |   6 +-
>  src/box/tuple_format.c |  30 +++------
>  src/box/tuple_format.h |  12 ++--
>  src/box/vy_stmt.c      |   9 +--
>  10 files changed, 238 insertions(+), 48 deletions(-)
>  create mode 100644 src/box/field_map.c
>  create mode 100644 src/box/field_map.h

Looks good to me. I'll commit as soon as the questions with patch #1
have been resolved.

  reply	other threads:[~2019-05-06 14:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-06 11:57 [PATCH v5 0/4] box: introduce multikey indexes in memtx Kirill Shcherbatov
2019-05-06 11:57 ` [PATCH v5 1/4] box: introduce tuple_format_iterator class Kirill Shcherbatov
2019-05-06 13:55   ` Vladimir Davydov
2019-05-06 14:32     ` [tarantool-patches] " Kirill Shcherbatov
2019-05-06 11:57 ` [PATCH v5 2/4] box: introduce field_map_builder class Kirill Shcherbatov
2019-05-06 14:22   ` Vladimir Davydov [this message]
2019-05-06 11:57 ` [PATCH v5 3/4] salad: introduce bps_tree_delete_identical routine Kirill Shcherbatov
2019-05-06 14:34   ` Vladimir Davydov
2019-05-06 14:55     ` [tarantool-patches] " Kirill Shcherbatov
2019-05-06 11:57 ` [PATCH v5 4/4] box: introduce multikey indexes in memtx Kirill Shcherbatov
2019-05-06 15:46   ` Vladimir Davydov
2019-05-06 16:35     ` [tarantool-patches] " Kirill Shcherbatov
2019-05-07  8:11       ` Vladimir Davydov
2019-05-07  8:28         ` Kirill Shcherbatov
2019-05-07 11:30           ` Vladimir Davydov
2019-05-07 13:13     ` Vladimir Davydov
2019-05-06 15:52 ` [PATCH v5 0/4] " Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190506142213.bvdgyoxie3calrvn@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=kshcherbatov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [PATCH v5 2/4] box: introduce field_map_builder class' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox