From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@freelists.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [PATCH 3/3] test: slab_arena -- Verify madvise
Date: Mon, 6 May 2019 13:55:52 +0300 [thread overview]
Message-ID: <20190506105552.ckbg5baemwroablb@esperanza> (raw)
In-Reply-To: <20190506104804.GO2488@uranus.lan>
On Mon, May 06, 2019 at 01:48:04PM +0300, Cyrill Gorcunov wrote:
> On Mon, May 06, 2019 at 01:45:20PM +0300, Vladimir Davydov wrote:
> > [Cc += Alexander re tests]
> >
> > On Wed, May 01, 2019 at 06:50:06PM +0300, Cyrill Gorcunov wrote:
> > > Since madvise support depends on sys libraries
> > > and kernel version we print error if only small
> > > supports it and /proc/self/smaps provide more
> > > less decent VmFlags.
> >
> > TBO I wouldn't bother testing this feature at all, because it's way too
> > platform dependent.
>
> Test does check for /proc/self/smaps file present and for VmFlags entry
> present, if neither of it found we just exit silently, without errors.
Okay, I'm fine with it.
To be prudent though, we'd have to check that the flag is set not only
for the preallocated memory region, but also for slabs allocated
afterwards (see slab_map -> mmap_checked). Not sure if it's worth it
though.
next prev parent reply other threads:[~2019-05-06 10:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 15:50 [PATCH 0/3] small: Prepare ground for madvise Cyrill Gorcunov
2019-05-01 15:50 ` [PATCH 1/3] build: Check for madvise syscall Cyrill Gorcunov
2019-05-06 10:25 ` Vladimir Davydov
2019-05-06 10:39 ` Cyrill Gorcunov
2019-05-01 15:50 ` [PATCH 2/3] slab_arena: Provide slab_arena_madvise_create to madvice slabs Cyrill Gorcunov
2019-05-06 10:38 ` Vladimir Davydov
2019-05-06 11:03 ` Cyrill Gorcunov
2019-05-06 13:46 ` Alexander Turenko
2019-05-01 15:50 ` [PATCH 3/3] test: slab_arena -- Verify madvise Cyrill Gorcunov
2019-05-06 10:45 ` Vladimir Davydov
2019-05-06 10:48 ` Cyrill Gorcunov
2019-05-06 10:55 ` Vladimir Davydov [this message]
2019-05-06 10:57 ` Cyrill Gorcunov
2019-05-06 11:04 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506105552.ckbg5baemwroablb@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH 3/3] test: slab_arena -- Verify madvise' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox