From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tml <tarantool-patches@freelists.org>
Subject: Re: [PATCH 1/3] build: Check for madvise syscall
Date: Mon, 6 May 2019 13:39:54 +0300 [thread overview]
Message-ID: <20190506103954.GN2488@uranus.lan> (raw)
In-Reply-To: <20190506102514.4vi5kbokus4gfkgq@esperanza>
On Mon, May 06, 2019 at 01:25:14PM +0300, Vladimir Davydov wrote:
> On Wed, May 01, 2019 at 06:50:04PM +0300, Cyrill Gorcunov wrote:
> > Need to check if madvise is present in the system
>
> I don't think there's much point in splitting this change in three
> patches. Please squash. OTOH it'd be nice to see how this API is
> intended to be used within Tarantool. Could you please submit the
> patch utilizing this feature in the same series?
OK, will do.
> >
> > Part of #3509
>
> There's no issue 3509 in tarantool/small repository. Please paste the
> full link instead - GitHub web interface knows how to show them.
OK
> >
> > +check_function_exists(madvise TARANTOOL_SMALL_HAS_MADVISE)
>
> I think we'd better check that MADV_DONTDUMP is available with the aid
> of check_symbol_exists.
OK
next prev parent reply other threads:[~2019-05-06 10:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 15:50 [PATCH 0/3] small: Prepare ground for madvise Cyrill Gorcunov
2019-05-01 15:50 ` [PATCH 1/3] build: Check for madvise syscall Cyrill Gorcunov
2019-05-06 10:25 ` Vladimir Davydov
2019-05-06 10:39 ` Cyrill Gorcunov [this message]
2019-05-01 15:50 ` [PATCH 2/3] slab_arena: Provide slab_arena_madvise_create to madvice slabs Cyrill Gorcunov
2019-05-06 10:38 ` Vladimir Davydov
2019-05-06 11:03 ` Cyrill Gorcunov
2019-05-06 13:46 ` Alexander Turenko
2019-05-01 15:50 ` [PATCH 3/3] test: slab_arena -- Verify madvise Cyrill Gorcunov
2019-05-06 10:45 ` Vladimir Davydov
2019-05-06 10:48 ` Cyrill Gorcunov
2019-05-06 10:55 ` Vladimir Davydov
2019-05-06 10:57 ` Cyrill Gorcunov
2019-05-06 11:04 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506103954.GN2488@uranus.lan \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH 1/3] build: Check for madvise syscall' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox