From: Alexander Turenko <alexander.turenko@tarantool.org>
To: avtikhon <avtikhon@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v2] travis-ci: set jobs not to stop on failed tests
Date: Mon, 6 May 2019 11:39:02 +0300 [thread overview]
Message-ID: <20190506083901.rnabgyqk3xcbylpi@tkn_work_nb> (raw)
In-Reply-To: <f1939ec23b5a9fc2ec5a6b6f94872c066603febb.1557124942.git.avtikhon@tarantool.org>
Pushed to master and 2.1.
WBR, Alexander Turenko.
On Mon, May 06, 2019 at 09:47:14AM +0300, avtikhon wrote:
> From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
>
> Added --force flag to travis-ci jobs not to stop on failed tests.
> Due to any found failed test breaks the testing it masks the other
> fails and in the following ways it's not good:
> - flaky test masks real problem
> - release testing needs overall result to fix it fast
> - parallel testing may produce flaky test
>
> Close: #4131
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-3863-test-in-parallel-force
> Issue: https://github.com/tarantool/tarantool/issues/4131
>
> .travis.mk | 6 +++---
> rpm/tarantool.spec | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/.travis.mk b/.travis.mk
> index 973c6a7c7..4ac3fc11a 100644
> --- a/.travis.mk
> +++ b/.travis.mk
> @@ -42,7 +42,7 @@ deps_ubuntu:
> test_ubuntu: deps_ubuntu
> cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_WERROR=ON ${CMAKE_EXTRA_PARAMS}
> make -j8
> - cd test && /usr/bin/python test-run.py -j 1
> + cd test && /usr/bin/python test-run.py --force -j 1
>
> deps_osx:
> brew update
> @@ -59,13 +59,13 @@ test_osx: deps_osx
> ulimit -S -n 20480 || :
> ulimit -n
> make -j8
> - cd test && python test-run.py -j 1 unit/ app/ app-tap/ box/ box-tap/
> + cd test && python test-run.py --force -j 1 unit/ app/ app-tap/ box/ box-tap/
>
> coverage_ubuntu: deps_ubuntu
> cmake . -DCMAKE_BUILD_TYPE=Debug -DENABLE_GCOV=ON
> make -j8
> # Enable --long tests for coverage
> - cd test && /usr/bin/python test-run.py -j 1 --long
> + cd test && /usr/bin/python test-run.py --force -j 1 --long
> lcov --compat-libtool --directory src/ --capture --output-file coverage.info.tmp
> lcov --compat-libtool --remove coverage.info.tmp 'tests/*' 'third_party/*' '/usr/*' \
> --output-file coverage.info
> diff --git a/rpm/tarantool.spec b/rpm/tarantool.spec
> index c87b1667d..8bee71ed0 100644
> --- a/rpm/tarantool.spec
> +++ b/rpm/tarantool.spec
> @@ -150,7 +150,7 @@ echo "self.skip = True" > ./test/app/socket.skipcond
> # https://github.com/tarantool/tarantool/issues/1322
> echo "self.skip = True" > ./test/app/digest.skipcond
> # run a safe subset of the test suite
> -cd test && ./test-run.py -j 1 unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/
> +cd test && ./test-run.py --force -j 1 unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/
> %endif
>
> %pre
> --
> 2.17.1
>
prev parent reply other threads:[~2019-05-06 8:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 6:47 [tarantool-patches] " avtikhon
2019-05-06 8:39 ` Alexander Turenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506083901.rnabgyqk3xcbylpi@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2] travis-ci: set jobs not to stop on failed tests' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox