From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@freelists.org>
Subject: Re: [PATCH] core/coio_file: copyfile -- Make it behave as regular cp
Date: Mon, 6 May 2019 11:37:29 +0300 [thread overview]
Message-ID: <20190506083729.cfyyu7pag7hvlgif@esperanza> (raw)
In-Reply-To: <20190504154922.30072-1-gorcunov@gmail.com>
On Sat, May 04, 2019 at 06:49:22PM +0300, Cyrill Gorcunov wrote:
> Traditional cp utility opens destination with O_TRUNC
> flag, iow it drops old content of the target file if
> such exists.
>
> Fixes #4181
> ---
> https://github.com/tarantool/tarantool/issues/4181
>
> Guys, take a look please, this is change in behaviour but
> should be acceptable.
>
> Also I just wondered that most of tests in test/app/fio.test.lua
> do pass octal modes as 0777 while lua's number parser simply doesn't
> understand octal form. So that I had to pass mode 420 by hands which
> is an alias to 0644.
I guess we should change 0644 to tonumber('644', 8) across the whole
test suite. Could you please do it in a separate patch?
Anyway, the new test case passes both with and without this patch, which
means it's useless. Please make sure it fails without the changes made
to the code by this patch.
Thanks.
next prev parent reply other threads:[~2019-05-06 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 15:49 Cyrill Gorcunov
2019-05-06 8:37 ` Vladimir Davydov [this message]
2019-05-06 8:43 ` Cyrill Gorcunov
2019-05-06 9:59 ` [PATCH v2] " Cyrill Gorcunov
2019-05-06 10:09 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506083729.cfyyu7pag7hvlgif@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] core/coio_file: copyfile -- Make it behave as regular cp' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox