From: Konstantin Osipov <kostja@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 1/5] swim: do not use ev_timer_start
Date: Wed, 1 May 2019 08:09:47 +0300 [thread overview]
Message-ID: <20190501050947.GA1139@atlas> (raw)
In-Reply-To: <55eb3963102ddf0f83e0358d7041d6e2fabd729c.1556663421.git.v.shpilevoy@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/05/01 08:07]:
> Appeared that libev changes 'ev_timer.at' field to a remaining
> time value, and it can't be used as a storage for a timeout. By
> the same reason ev_timer_start() can't be used to reuse a timer.
>
> On the contrary, 'ev_timer.repeat' is not touched by libev, and
> ev_timer_again() allows to reuse a timer.
>
> This patch replaces 'at' with 'repeat' and ev_timer_start() with
> ev_timer_again().
>
> The bug was not detected by unit tests, because they implement
> their own event loop and do not change ev_timer.at. Now they do
> to prevent a regression.
OK to push.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
next prev parent reply other threads:[~2019-05-01 5:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 22:31 [tarantool-patches] [PATCH 0/5] swim lua preparation Vladislav Shpilevoy
2019-04-30 22:31 ` [tarantool-patches] [PATCH 1/5] swim: do not use ev_timer_start Vladislav Shpilevoy
2019-05-01 5:09 ` Konstantin Osipov [this message]
2019-04-30 22:31 ` [tarantool-patches] [PATCH 2/5] swim: introduce member reference API Vladislav Shpilevoy
2019-05-01 5:15 ` [tarantool-patches] " Konstantin Osipov
2019-05-02 15:10 ` Vladislav Shpilevoy
2019-05-02 15:46 ` Konstantin Osipov
2019-05-02 17:32 ` Vladislav Shpilevoy
2019-04-30 22:31 ` [tarantool-patches] [PATCH 3/5] sio: return 'no host' flag from sio_uri_to_addr() Vladislav Shpilevoy
2019-05-01 5:18 ` [tarantool-patches] " Konstantin Osipov
2019-04-30 22:31 ` [tarantool-patches] [PATCH 4/5] swim: allow to omit host in URI Vladislav Shpilevoy
2019-05-01 5:20 ` [tarantool-patches] " Konstantin Osipov
2019-05-02 15:10 ` Vladislav Shpilevoy
2019-04-30 22:31 ` [tarantool-patches] [PATCH 5/5] swim: explicitly stop old ev_io input/output on rebind Vladislav Shpilevoy
2019-05-01 5:21 ` [tarantool-patches] " Konstantin Osipov
2019-05-02 17:32 ` [tarantool-patches] Re: [PATCH 0/5] swim lua preparation Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501050947.GA1139@atlas \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 1/5] swim: do not use ev_timer_start' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox