From: Konstantin Osipov <kostja@tarantool.org> To: Vladimir Davydov <vdavydov.dev@gmail.com> Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>, tarantool-patches@freelists.org Subject: Re: [tarantool-patches] Re: [PATCH v4 3/3] box: introduce multikey indexes in memtx Date: Tue, 30 Apr 2019 12:48:17 +0300 [thread overview] Message-ID: <20190430094817.GA5685@atlas> (raw) In-Reply-To: <20190430084353.zq2uxs23bxwxo26i@esperanza> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/04/30 12:43]: > > > That would emphasize that it inserts a single multikey entry. > > > > I like "memtx_tree_index_replace_multikey_step". What do you think? > > Better _one or _do_replace IMO :) We typically use _one suffix for > splitting functions like that in the code; _step sounds like it is > about iterators while it is not. _one or replace_one_key > > >> +/** > > >> + * Check if child_field may be attached to parent_field, > > >> + * update the parent_field container type if required. > > >> + */ > > >> +static int > > >> +tuple_field_ensure_child_compatibility(struct tuple_field *parent, > > >> + struct tuple_field *child) > > > > > > Wouldn't tuple_format_check_field be a better name? > > I am not shure. > > This code not only check some cases, but also may change field type > > when it is possible. > > "enshure compatibility" -- make everything okey or die then split it into two functions? -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
prev parent reply other threads:[~2019-04-30 9:48 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-19 14:14 [PATCH v4 0/3] " Kirill Shcherbatov 2019-04-19 14:14 ` [PATCH v4 1/3] box: introduce tuple_parse_iterator class Kirill Shcherbatov 2019-04-29 15:41 ` Vladimir Davydov 2019-04-19 14:14 ` [PATCH v4 2/3] box: introduce field_map_builder class Kirill Shcherbatov 2019-04-19 14:14 ` [PATCH v4 3/3] box: introduce multikey indexes in memtx Kirill Shcherbatov 2019-04-29 16:06 ` Vladimir Davydov 2019-04-30 8:22 ` [tarantool-patches] " Kirill Shcherbatov 2019-04-30 8:43 ` Vladimir Davydov 2019-04-30 9:48 ` Konstantin Osipov [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190430094817.GA5685@atlas \ --to=kostja@tarantool.org \ --cc=kshcherbatov@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [tarantool-patches] Re: [PATCH v4 3/3] box: introduce multikey indexes in memtx' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox