Re: [tarantool-patches] [PATCH v3 7/7] Add merger for tuple streams (Lua part)

[Konstantin Osipov <kostja.osipov@gmail.com>]

* Alexander Turenko <alexander.turenko@tarantool.org> [19/04/10 18:23]:
> 
The api is generally LGTM, one comment below:

> A merger is a special kind of a source, which is created from a key_def
> object and a set of sources. It performs a kind of the merge sort:
> chooses a source with a minimal / maximal tuple on each step, consumes
> a tuple from this source and repeats. The API to create a merger is the
> following:
> 
> ```lua
> local ctx = merger.context.new(key_def.new(<...>))
> local sources = {<...>}
> local merger_inst = merger.new(ctx, sources, {

    Why do you need a separate object used only to construct a
    merger? Why not pass all parameters into merger.new?

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov