From: Konstantin Osipov <kostja@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 2/6] test: remove swim packet filter destructors
Date: Wed, 24 Apr 2019 19:37:50 +0300 [thread overview]
Message-ID: <20190424163750.GB13687@atlas> (raw)
In-Reply-To: <483a32cd0f1e92a2163ed4875cd9ca2fb450fa3d.1556116199.git.v.shpilevoy@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/04/24 18:50]:
> Swim test packet filters are supposed to filter out packets
> matching certain criteria or with a probability. They were
> implemented as a filter-function and userdata passed into the
> former on each invocation. Usually it was allocated on heap and
> needed deletion. But it appeared that much simpler is to store
> the filters inside struct swim_node, pass it as userdata, and get
> rid of userdata destructors and dynamic allocations.
>
> The patch is motivated by necessity to add one new filter, which
> anyway will need struct swim_node as userdata.
OK to push.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-04-24 16:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 14:36 [tarantool-patches] [PATCH 0/6] swim suspicion Vladislav Shpilevoy
2019-04-24 14:36 ` [tarantool-patches] [PATCH 1/6] test: rename swim_cluster_node to swim_cluster_member Vladislav Shpilevoy
2019-04-24 16:37 ` [tarantool-patches] " Konstantin Osipov
2019-04-24 14:36 ` [tarantool-patches] [PATCH 2/6] test: remove swim packet filter destructors Vladislav Shpilevoy
2019-04-24 16:37 ` Konstantin Osipov [this message]
2019-04-24 14:36 ` [tarantool-patches] [PATCH 3/6] test: introduce swim packet filter by destination address Vladislav Shpilevoy
2019-04-24 16:38 ` [tarantool-patches] " Konstantin Osipov
2019-04-24 14:36 ` [tarantool-patches] [PATCH 4/6] swim: wrap sio_strfaddr() Vladislav Shpilevoy
2019-04-24 16:40 ` [tarantool-patches] " Konstantin Osipov
2019-04-24 20:23 ` Vladislav Shpilevoy
2019-04-25 10:34 ` Konstantin Osipov
2019-04-25 13:50 ` Vladislav Shpilevoy
2019-04-24 14:36 ` [tarantool-patches] [PATCH 5/6] swim: introduce routing Vladislav Shpilevoy
2019-04-24 16:46 ` [tarantool-patches] " Konstantin Osipov
2019-04-24 20:25 ` Vladislav Shpilevoy
2019-04-25 10:39 ` Konstantin Osipov
2019-04-25 13:50 ` Vladislav Shpilevoy
2019-04-25 13:57 ` Konstantin Osipov
2019-04-24 14:36 ` [tarantool-patches] [PATCH 6/6] swim: introduce suspicion Vladislav Shpilevoy
2019-04-24 17:01 ` [tarantool-patches] " Konstantin Osipov
2019-04-24 20:28 ` Vladislav Shpilevoy
2019-04-25 10:42 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424163750.GB13687@atlas \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 2/6] test: remove swim packet filter destructors' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox