From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org,
Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 1/1] tap: fix is_deeply box.NULL corner cases
Date: Wed, 24 Apr 2019 15:14:34 +0300 [thread overview]
Message-ID: <20190424121433.54daf5yejqar3f5d@tkn_work_nb> (raw)
In-Reply-To: <0e66ac3b-9c9d-6097-fd95-c6ec9ae43273@tarantool.org>
On Wed, Apr 24, 2019 at 03:02:32PM +0300, Vladislav Shpilevoy wrote:
>
>
> On 24/04/2019 14:57, Alexander Turenko wrote:
> >> @@ -163,6 +173,7 @@ local function is_deeply(test, got, expected, message, extra)
> >> extra = extra or {}
> >> extra.got = got
> >> extra.expected = expected
> >> + extra.strict = test.strict
> >
> > The 'extra' parameter is needed to provide a user more information in
> > case of a fail. Here we use it to push options for cmpdeeply(). I would
> > add 'opts' parameter instead.
> >
>
> If you do not like extra output about 'strict' value, then we
> could make it 'nil' by default, not 'false', and it will not
> be printed until someone starts to use it.
I'm ok if it is consistent with other such parameters. Kirill said it
is, so ok.
next prev parent reply other threads:[~2019-04-24 12:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 12:55 [tarantool-patches] [PATCH v1 " Kirill Shcherbatov
2019-04-23 14:12 ` [tarantool-patches] " Kirill Shcherbatov
2019-04-23 14:14 ` Vladislav Shpilevoy
2019-04-24 9:37 ` [tarantool-patches] [PATCH v2 " Kirill Shcherbatov
2019-04-24 11:23 ` [tarantool-patches] " Vladislav Shpilevoy
2019-04-24 11:56 ` Kirill Shcherbatov
2019-04-24 12:01 ` Vladislav Shpilevoy
2019-04-24 11:57 ` Alexander Turenko
2019-04-24 12:02 ` Vladislav Shpilevoy
2019-04-24 12:14 ` Alexander Turenko [this message]
2019-04-25 10:29 ` [tarantool-patches] Re: [PATCH v1 " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424121433.54daf5yejqar3f5d@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v2 1/1] tap: fix is_deeply box.NULL corner cases' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox