From: Kirill Yukhin <kyukhin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 1/1] sql: drop a useless check from lookupName()
Date: Tue, 23 Apr 2019 13:24:43 +0300 [thread overview]
Message-ID: <20190423102443.hbqaforngk7re7mp@tarantool.org> (raw)
In-Reply-To: <fb525c50e478d2832005fa8c1eed1d8666359bf6.1555958029.git.v.shpilevoy@tarantool.org>
Hello,
On 22 Apr 21:34, Vladislav Shpilevoy wrote:
> There was a variable used as a counter from 0 to
> uint32_t space_def->field_count. Obviously it can't be < 0, but
> there was a check for that. Drop it.
>
> The check was revealed during SQL BOOLEAN review, where one of
> patches gets rid of some explicit Expr.type assignments.
> ---
> Branch: https://github.com/tarantool/tarantool/tree/gerold103/drop-useless-check-from-resolve
I've checked your patch into master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-04-23 10:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 18:34 [tarantool-patches] " Vladislav Shpilevoy
2019-04-23 10:24 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423102443.hbqaforngk7re7mp@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 1/1] sql: drop a useless check from lookupName()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox