From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 7/6] swim: drop incarnation_inc parameter from update() routines
Date: Thu, 18 Apr 2019 21:20:19 +0300 [thread overview]
Message-ID: <20190418182019.GA26665@chai> (raw)
In-Reply-To: <2e76a679-c509-f12e-5abb-b1457ca478b0@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/04/18 21:18]:
> Update_addr and update_payload need to increment member's
> incarnation when it is self. For that they used a special
> parameter incarnation_inc set in 1 for self and in 0 for others.
>
> It was used to encapsulate incarnation update + event scheduling
> on member attribute updates, but on the other hand it broke
> another encapsulation level - there should not be exceptions for
> 'self' in these functions.
>
> This patch makes incarnation increment explicit in the places
> where 'self' is updated.
ok to push
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-04-18 18:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 22:22 [tarantool-patches] [PATCH 0/6] swim payload Vladislav Shpilevoy
2019-04-11 22:22 ` [tarantool-patches] [PATCH 1/6] swim: factor out MP_BIN decoding from swim_decode_uuid Vladislav Shpilevoy
2019-04-11 23:09 ` [tarantool-patches] " Konstantin Osipov
2019-04-12 19:23 ` Vladislav Shpilevoy
2019-04-11 22:22 ` [tarantool-patches] [PATCH 2/6] swim: replace event_bin and member_bin with the passport Vladislav Shpilevoy
2019-04-11 23:10 ` [tarantool-patches] " Konstantin Osipov
2019-04-12 19:23 ` Vladislav Shpilevoy
2019-04-11 22:22 ` [tarantool-patches] [PATCH 3/6] swim: factor out 'update' part of swim_member_upsert() Vladislav Shpilevoy
2019-04-11 23:11 ` [tarantool-patches] " Konstantin Osipov
2019-04-12 19:23 ` Vladislav Shpilevoy
2019-04-11 22:22 ` [tarantool-patches] [PATCH 4/6] test: generalize SWIM fake descriptor filters Vladislav Shpilevoy
2019-04-11 23:11 ` [tarantool-patches] " Konstantin Osipov
2019-04-12 19:23 ` Vladislav Shpilevoy
2019-04-11 22:22 ` [tarantool-patches] [PATCH 5/6] test: introduce new SWIM packet filter by component names Vladislav Shpilevoy
2019-04-11 23:11 ` [tarantool-patches] " Konstantin Osipov
2019-04-12 19:23 ` Vladislav Shpilevoy
2019-04-11 22:22 ` [tarantool-patches] [PATCH 6/6] swim: introduce payload Vladislav Shpilevoy
2019-04-18 15:12 ` [tarantool-patches] " Konstantin Osipov
2019-04-18 17:43 ` Vladislav Shpilevoy
2019-04-18 18:03 ` Konstantin Osipov
2019-04-18 20:40 ` Vladislav Shpilevoy
2019-04-18 17:43 ` [tarantool-patches] [PATCH 5.5/6] swim: rename TTL to TTD Vladislav Shpilevoy
2019-04-18 17:48 ` [tarantool-patches] " Konstantin Osipov
2019-04-18 20:40 ` Vladislav Shpilevoy
2019-04-18 18:16 ` [tarantool-patches] [PATCH 7/6] swim: drop incarnation_inc parameter from update() routines Vladislav Shpilevoy
2019-04-18 18:20 ` Konstantin Osipov [this message]
2019-04-18 20:40 ` [tarantool-patches] " Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418182019.GA26665@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 7/6] swim: drop incarnation_inc parameter from update() routines' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox