From: Konstantin Osipov <kostja@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 1/4] swim: move sockaddr_in checkers to swim_proto.h
Date: Thu, 18 Apr 2019 19:02:35 +0300 [thread overview]
Message-ID: <20190418160235.GA6442@chai> (raw)
In-Reply-To: <5554cf76-e1e1-6bde-1aaf-2ee856752523@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/04/18 18:27]:
> It's mainly against malicious and bad-formatter packets. Since
> the protocol will be public, it can happen that custom drivers
> will send bad packets.
This definitely needs a comment. Besides, it's a bad address then,
not empty address, and such messages should be simply rejected.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-04-18 16:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 19:56 [tarantool-patches] [PATCH 0/4] swim suspicion preparation Vladislav Shpilevoy
2019-04-17 19:56 ` [tarantool-patches] [PATCH 1/4] swim: move sockaddr_in checkers to swim_proto.h Vladislav Shpilevoy
2019-04-18 11:35 ` [tarantool-patches] " Vladislav Shpilevoy
2019-04-18 15:16 ` Konstantin Osipov
2019-04-18 15:24 ` Vladislav Shpilevoy
2019-04-18 16:02 ` Konstantin Osipov [this message]
2019-04-18 18:34 ` Vladislav Shpilevoy
2019-04-18 15:15 ` Konstantin Osipov
2019-04-17 19:56 ` [tarantool-patches] [PATCH 2/4] swim: extract binary ip/port into a separate struct Vladislav Shpilevoy
2019-04-18 15:17 ` [tarantool-patches] " Konstantin Osipov
2019-04-18 18:34 ` Vladislav Shpilevoy
2019-04-17 19:56 ` [tarantool-patches] [PATCH 3/4] swim: fix a bug with invalidation of round msg in fly Vladislav Shpilevoy
2019-04-18 15:19 ` [tarantool-patches] " Konstantin Osipov
2019-04-18 18:34 ` Vladislav Shpilevoy
2019-04-17 19:56 ` [tarantool-patches] [PATCH 4/4] swim: do not rebuild packet meta multiple times Vladislav Shpilevoy
2019-04-18 17:23 ` [tarantool-patches] " Konstantin Osipov
2019-04-18 18:34 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418160235.GA6442@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 1/4] swim: move sockaddr_in checkers to swim_proto.h' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox