From: Konstantin Osipov <kostja@tarantool.org> To: tarantool-patches@freelists.org Cc: Kirill Yukhin <kyukhin@tarantool.org> Subject: [tarantool-patches] Re: [PATCH] Set format for spaces with sysview engine Date: Thu, 18 Apr 2019 17:16:26 +0300 [thread overview] Message-ID: <20190418141626.GA7924@chai> (raw) In-Reply-To: <5783e513-19e4-182b-941b-9070a7266c92@tarantool.org> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/04/18 17:12]: > Now finally technically is ok except that I will never agree > with the test-file-per-issue policy. It is ridiculous. We should not use it, Kirill, please don't. > > Following this logic I should name the whole swim subsystem > test file like gh-3234-swim and rename the binary protocol > test file into gh-3234-swim_proto - two files about the same > issue with an ugly prefix looking like it is a fix of a bug. > -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-04-18 14:16 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-15 13:35 [tarantool-patches] " Kirill Yukhin 2019-04-16 15:13 ` [tarantool-patches] " Vladislav Shpilevoy 2019-04-17 8:13 ` Kirill Yukhin 2019-04-17 10:11 ` Vladislav Shpilevoy 2019-04-18 8:16 ` Kirill Yukhin 2019-04-18 10:43 ` Vladislav Shpilevoy 2019-04-18 11:14 ` Kirill Yukhin 2019-04-18 11:39 ` Vladislav Shpilevoy 2019-04-18 12:08 ` Kirill Yukhin 2019-04-18 12:43 ` Vladislav Shpilevoy 2019-04-18 13:25 ` Kirill Yukhin 2019-04-18 14:18 ` Konstantin Osipov 2019-04-19 11:46 ` Kirill Yukhin 2019-04-20 22:36 ` Alexander Turenko 2019-04-21 17:06 ` Vladislav Shpilevoy 2019-04-21 18:19 ` Konstantin Osipov 2019-04-18 14:16 ` Konstantin Osipov [this message] 2019-04-17 13:38 ` Konstantin Osipov 2019-04-18 8:23 ` Kirill Yukhin 2019-04-19 11:38 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190418141626.GA7924@chai \ --to=kostja@tarantool.org \ --cc=kyukhin@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH] Set format for spaces with sysview engine' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox