[tarantool-patches] Re: [PATCH] Set format for spaces with sysview engine

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 18 апр 14:39, Vladislav Shpilevoy wrote:
> 
> 
> On 18/04/2019 14:14, Kirill Yukhin wrote:
> > Hello,
> > 
> > On 18 апр 13:43, Vladislav Shpilevoy wrote:
> >> Hi! Thanks for the fixes! See 4 comments below.
> >>
> >> 1. Now I see that sysview tuple format leaks. Please,
> >> apply this diff:
> >>
> >> ======================================================
> >> diff --git a/src/box/sysview.c b/src/box/sysview.c
> >> index 0b07c9f4a..96c5e78ca 100644
> >> --- a/src/box/sysview.c
> >> +++ b/src/box/sysview.c
> >> @@ -545,6 +545,8 @@ sysview_engine_create_space(struct engine *engine, struct space_def *def,
> >>  		free(space);
> >>  		return NULL;
> >>  	}
> >> +	/* Format is now referenced by the space. */
> >> +	tuple_format_unref(format);
> >>  	return space;
> >>  }
> >> ======================================================
> > 
> > Done.
> > 
> > Branch force-pushed and re-tested.
> 
> How was it retested?

I didn't staged updated result. Done.

--
Regards, Kirill Yukhin