From: Kirill Yukhin <kyukhin@tarantool.org>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org, v.shpilevoy@tarantool.org
Subject: [tarantool-patches] Re: [PATCH] Set format for spaces with sysview engine
Date: Thu, 18 Apr 2019 11:23:02 +0300 [thread overview]
Message-ID: <20190418082302.kxmym7oqhph7l3mm@tarantool.org> (raw)
In-Reply-To: <20190417133845.GA12601@chai>
Hello,
On 17 апр 16:38, Konstantin Osipov wrote:
> * Kirill Yukhin <kyukhin@tarantool.org> [19/04/15 17:06]:
> > +/**
> > + * Create an array of key_defs from array of index definitions.
>
> Why allocate on region? We usually allocate key_defs with
> malloc().
I didn't change this peace of code. It was always alloacted on a region.
See [1].
>
> The function should be called index_def_to_key_def() or similar.
Done (in another mail).
--
Regards, Kirill Yukhin
[1] - https://github.com/tarantool/tarantool/blob/master/src/box/memtx_space.c#L982
next prev parent reply other threads:[~2019-04-18 8:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 13:35 [tarantool-patches] " Kirill Yukhin
2019-04-16 15:13 ` [tarantool-patches] " Vladislav Shpilevoy
2019-04-17 8:13 ` Kirill Yukhin
2019-04-17 10:11 ` Vladislav Shpilevoy
2019-04-18 8:16 ` Kirill Yukhin
2019-04-18 10:43 ` Vladislav Shpilevoy
2019-04-18 11:14 ` Kirill Yukhin
2019-04-18 11:39 ` Vladislav Shpilevoy
2019-04-18 12:08 ` Kirill Yukhin
2019-04-18 12:43 ` Vladislav Shpilevoy
2019-04-18 13:25 ` Kirill Yukhin
2019-04-18 14:18 ` Konstantin Osipov
2019-04-19 11:46 ` Kirill Yukhin
2019-04-20 22:36 ` Alexander Turenko
2019-04-21 17:06 ` Vladislav Shpilevoy
2019-04-21 18:19 ` Konstantin Osipov
2019-04-18 14:16 ` Konstantin Osipov
2019-04-17 13:38 ` Konstantin Osipov
2019-04-18 8:23 ` Kirill Yukhin [this message]
2019-04-19 11:38 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418082302.kxmym7oqhph7l3mm@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH] Set format for spaces with sysview engine' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox