From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@freelists.org>
Subject: Re: [tarantool-patches] [PATCH] fiber: Unify sizeof operator
Date: Tue, 16 Apr 2019 20:37:18 +0300 [thread overview]
Message-ID: <20190416173718.b3yscfqg3epmx4g4@esperanza> (raw)
In-Reply-To: <20190415211450.20728-1-gorcunov@gmail.com>
On Tue, Apr 16, 2019 at 12:14:50AM +0300, Cyrill Gorcunov wrote:
> We use sizeof as a function in most of the overall code,
> fix this nit.
> ---
> src/lib/core/fiber.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c
> index 283a53d58..ce90f930c 100644
> --- a/src/lib/core/fiber.c
> +++ b/src/lib/core/fiber.c
> @@ -1363,7 +1363,7 @@ cord_costart(struct cord *cord, const char *name, fiber_func f, void *arg)
> void
> cord_set_name(const char *name)
> {
> - snprintf(cord()->name, sizeof cord()->name, "%s", name);
> + snprintf(cord()->name, sizeof(cord()->name), "%s", name);
> /* Main thread's name will replace process title in ps, skip it */
> if (cord_is_main())
> return;
Trivial. Pushed to master.
prev parent reply other threads:[~2019-04-16 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 21:14 Cyrill Gorcunov
2019-04-16 17:37 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416173718.b3yscfqg3epmx4g4@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH] fiber: Unify sizeof operator' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox