From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tml <tarantool-patches@freelists.org>
Subject: Re: [PATCH] lib/core/coio_file: Use eio_sendfile_sync instead of a chunk mode
Date: Fri, 12 Apr 2019 17:59:25 +0300 [thread overview]
Message-ID: <20190412145925.GD20557@uranus> (raw)
In-Reply-To: <20190412145347.sl3m5zynsg5sujg5@esperanza>
On Fri, Apr 12, 2019 at 05:53:47PM +0300, Vladimir Davydov wrote:
>
> True, I don't think it's worth testing it.
>
> I just wanted to say that we need to make sure it works - check it
> manually and I will too.
Current tests are passed even without "cycled sendfile" simply
because current tests are not operating with huge files (i ran
them manually before sending the patch). I'll recheck everything
once again before sending v2. Thanks for review!
> Alternatively, we could add an error injection, reducing the sendfile
> copy size, but I think it's not really necessary.
OK
prev parent reply other threads:[~2019-04-12 14:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 19:36 Cyrill Gorcunov
2019-04-12 13:43 ` Vladimir Davydov
2019-04-12 14:05 ` Cyrill Gorcunov
2019-04-12 14:19 ` Vladimir Davydov
2019-04-12 14:42 ` Cyrill Gorcunov
2019-04-12 14:53 ` Vladimir Davydov
2019-04-12 14:59 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412145925.GD20557@uranus \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH] lib/core/coio_file: Use eio_sendfile_sync instead of a chunk mode' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox