From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@freelists.org>
Subject: Re: [PATCH] lib/core/coio_file: Use eio_sendfile_sync instead of a chunk mode
Date: Fri, 12 Apr 2019 17:53:47 +0300 [thread overview]
Message-ID: <20190412145347.sl3m5zynsg5sujg5@esperanza> (raw)
In-Reply-To: <20190412144212.GC20557@uranus>
On Fri, Apr 12, 2019 at 05:42:12PM +0300, Cyrill Gorcunov wrote:
> On Fri, Apr 12, 2019 at 05:19:16PM +0300, Vladimir Davydov wrote:
> ...
> > > But I agree that using sendfile here actually may trim file. I'll take
> > > a look at evening but I think we should rather use sendfile with offsets
> > > in a cycle. Seriouly, using 4K buffer is the worst possible algo :)
> >
> > Yeah, it would be great to make use of sendfile, but we must make sure
> > we won't occasionally break anything.
>
> I will have to update tests. The problem only is that we've to test
> big files here, have no clue if our CI engine will allow us to
> generate/copy such sizes.
True, I don't think it's worth testing it.
I just wanted to say that we need to make sure it works - check it
manually and I will too.
Alternatively, we could add an error injection, reducing the sendfile
copy size, but I think it's not really necessary.
next prev parent reply other threads:[~2019-04-12 14:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 19:36 Cyrill Gorcunov
2019-04-12 13:43 ` Vladimir Davydov
2019-04-12 14:05 ` Cyrill Gorcunov
2019-04-12 14:19 ` Vladimir Davydov
2019-04-12 14:42 ` Cyrill Gorcunov
2019-04-12 14:53 ` Vladimir Davydov [this message]
2019-04-12 14:59 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412145347.sl3m5zynsg5sujg5@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] lib/core/coio_file: Use eio_sendfile_sync instead of a chunk mode' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox