From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH] vinyl: take into account primary key lookup in latency accounting
Date: Thu, 11 Apr 2019 23:12:19 +0300 [thread overview]
Message-ID: <20190411201218.nmfdpxpncb5ro52l@esperanza> (raw)
In-Reply-To: <20190411200434.GB25603@chai>
On Thu, Apr 11, 2019 at 11:04:34PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/04/11 20:29]:
> > Currently, latency accounting and warning lives in vy_point_lookup and
> > vy_read_iterator_next. As a result, we don't take into account full by
> > partial tuple lookup in it while it can take quite a while, especially
> > if there are lots of deferred DELETE statements we have to skip. So this
> > patch moves latency accounting to the upper level, namely to vy_get and
> > vinyl_iterator_{primary,secondary}_next.
>
> I believe this si a temporary patch as long as it uses
> clock_monotonic :)
It doesn't. I just moves latency accounting to the upper level to take
into account the time spent on skipping deferred DELETEs. It still uses
ev_monotonic_now for latency accounting.
next prev parent reply other threads:[~2019-04-11 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 17:24 Vladimir Davydov
2019-04-11 20:04 ` Konstantin Osipov
2019-04-11 20:12 ` Vladimir Davydov [this message]
2019-04-11 20:30 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411201218.nmfdpxpncb5ro52l@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] vinyl: take into account primary key lookup in latency accounting' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox